remove stop if stoppable

Author: lia-viam

src/viam/sdk/module/service.cpp

@@ -124,10 +124,8 @@ struct ModuleService::ServiceImpl : viam::module::v1::ModuleService::Service {
         }
 
         // if the type isn't reconfigurable by default, replace it
-        try {
-            Stoppable::stop_if_stoppable(res);
-        } catch (const std::exception& err) {
-            VIAM_SDK_LOG(error) << "unable to stop resource: " << err.what();
+        if (auto stoppable = std::dynamic_pointer_cast<Stoppable>(res)) {
+            stoppable->stop();
         }
 
         const std::shared_ptr<const ModelRegistration> reg =

src/viam/sdk/resource/stoppable.cpp

@@ -6,13 +6,5 @@ namespace sdk {
 Stoppable::~Stoppable() = default;
 Stoppable::Stoppable() = default;
 
-void Stoppable::stop_if_stoppable(const std::shared_ptr<Resource>& resource,
-                                  const ProtoStruct& extra) {
-    auto stoppable_res = std::dynamic_pointer_cast<Stoppable>(resource);
-    if (stoppable_res) {
-        stoppable_res->stop(extra);
-    }
-}
-
 }  // namespace sdk
 }  // namespace viam

src/viam/sdk/resource/stoppable.hpp

@@ -17,18 +17,6 @@ class Stoppable {
         return stop({});
     }
 
-    /// @brief Stops a Resource if it is Stoppable.
-    /// @param resource The Resource to stop.
-    /// @param extra Extra arguments to pass to the resource's `stop` method.
-    static void stop_if_stoppable(const std::shared_ptr<Resource>& resource,
-                                  const ProtoStruct& extra);
-
-    /// @brief Stops a Resource if it is Stoppable.
-    /// @param resource The Resource to stop.
-    inline static void stop_if_stoppable(const std::shared_ptr<Resource>& resource) {
-        return stop_if_stoppable(resource, {});
-    }
-
    protected:
     explicit Stoppable();
 };