do reconfigure manually

Author: lia-viam

src/viam/sdk/module/service.cpp

@@ -116,12 +116,10 @@ struct ModuleService::ServiceImpl : viam::module::v1::ModuleService::Service {
                                 "unable to reconfigure resource " + cfg.resource_name().name() +
                                     " as it doesn't exist.");
         }
-        try {
-            Reconfigurable::reconfigure_if_reconfigurable(res, deps, cfg);
-            res->set_log_level(cfg.get_log_level());
+
+        if (auto reconfigurable = std::dynamic_pointer_cast<Reconfigurable>(res)) {
+            reconfigurable->reconfigure(deps, cfg);
             return grpc::Status();
-        } catch (const std::exception& exc) {
-            return grpc::Status(::grpc::INTERNAL, exc.what());
         }
 
         // if the type isn't reconfigurable by default, replace it

src/viam/sdk/resource/reconfigurable.cpp

@@ -8,14 +8,5 @@ namespace sdk {
 Reconfigurable::~Reconfigurable() = default;
 Reconfigurable::Reconfigurable() = default;
 
-void Reconfigurable::reconfigure_if_reconfigurable(const std::shared_ptr<Resource>& resource,
-                                                   const Dependencies& deps,
-                                                   const ResourceConfig& cfg) {
-    auto reconfigurable_res = std::dynamic_pointer_cast<Reconfigurable>(resource);
-    if (reconfigurable_res) {
-        reconfigurable_res->reconfigure(deps, cfg);
-    }
-}
-
 }  // namespace sdk
 }  // namespace viam

src/viam/sdk/resource/reconfigurable.hpp

@@ -15,14 +15,6 @@ class Reconfigurable {
     /// @param cfg The resource's config.
     virtual void reconfigure(const Dependencies& deps, const ResourceConfig& cfg) = 0;
 
-    /// @brief Reconfigures a resource if it is Reconfigurable.
-    /// @param resource the Resource to reconfigure.
-    /// @param deps Dependencies of the resource.
-    /// @param cfg The resource's config.
-    static void reconfigure_if_reconfigurable(const std::shared_ptr<Resource>& resource,
-                                              const Dependencies& deps,
-                                              const ResourceConfig& cfg);
-
    protected:
     explicit Reconfigurable();
 };