lint

Author: randhid

src/viam/sdk/services/discovery.hpp

@@ -14,9 +14,9 @@ namespace sdk {
 /// @defgroup Discovery Classes related to the Discovery service.
 
 /// @class Discovery discovery.hpp "services/discovery.hpp"
-/// @brief A `Discovery` service is used to discover resources that are physically connected to 
+/// @brief A `Discovery` service is used to discover resources that are physically connected to
 /// your machine.
-/// @ingroup Discovery 
+/// @ingroup Discovery
 ///
 /// This acts as an abstract parent class to be inherited from by any drivers representing
 /// specific discovery implementations. This class cannot be used on its own.
@@ -29,8 +29,8 @@ class Discovery : public Service {
         return discover_resources({});
     }
 
-    /// @brief Discover valid viam configuration of resources that are physically 
-    /// connected to your machine. 
+    /// @brief Discover valid viam configuration of resources that are physically
+    /// connected to your machine.
     virtual std::vector<ResourceConfig> discover_resources(const ProtoStruct& extra) = 0;
 
     /// @brief Do an arbitrary command.

src/viam/sdk/services/private/discovery_client.cpp

@@ -1,4 +1,4 @@
-#include <viam/sdk/services/private/discovery_client.hpp> 
+#include <viam/sdk/services/private/discovery_client.hpp>
 
 #include <viam/api/service/discovery/v1/discovery.grpc.pb.h>
 #include <viam/api/service/discovery/v1/discovery.pb.h>
@@ -10,25 +10,23 @@ namespace sdk {
 namespace impl {
 
 DiscoveryClient::DiscoveryClient(std::string name std::shared_ptr<grpc::Channel> channel)
-        : Discovery(std::move(name)), 
-          stub_(viam::service::discovery::v1::DiscoveryService::NewStub(channel)),
-          channel_(std::move(channel)) {}
- 
+    : Discovery(std::move(name)), 
+        stub_(viam::service::discovery::v1::DiscoveryService::NewStub(channel)),
+        channel_(std::move(channel)) {}
+
 std::vector<ResourceConfig> DiscoveryClient::discover_resources(const ProtoStruct& extra) {
     return make_client_helper(this, *stub_, &StubType::DiscoverResources)
         .with(extra)
-        .invoke([](auto& response) {return from_proto(response);});
+        .invoke([](auto& response) { return from_proto(response); });
 }
 
 ProtoStruct DiscoveryClient::do_command(const ProtoStruct& extra) {
     return make_client_helper(this, *stub_, &StubType::DoCommand)
-        .with([&](auto& request) {*request.mutable_command() = to_proto(command); })
-        .invoke([](auto& response) {return from_proto(response.result());});
+        .with([&](auto& request) { *request.mutable_command() = to_proto(command); })
+        .invoke([](auto& response) { return from_proto(response.result()); });
 }
 
 
-} // namespace impl
-
-
-} //namespace sdk
-} //namespace viam
+}  // namespace impl
+}  // namespace sdk
+}  // namespace viam

src/viam/sdk/services/private/discovery_client.hpp

@@ -34,6 +34,6 @@ class DiscoveryClient : public Discovery {
     std::shared_ptr<grpc::Channel> channel_;
 };
 
-} // namespace impl
-} // namespace sdk
-} // namespace viam
+}  // namespace impl
+}  // namespace sdk
+}  // namespace viam

src/viam/sdk/services/private/discovery_server.cpp

@@ -15,7 +15,8 @@ ::grpc::Status DiscoveryServer::DiscoverResources(
     ::viam::service::discovery::v1::DiscoverResourcesResponse* response) noexcept {
     return make_service_helper<Discovery>(
         "DiscoveryServer::DiscoverResources", this, request)([&](auto& helper, auto& discovery) {
-        const std::vector<ResourceConfig> resources = discovery->discover_resources(helper.getExtra());
+        const std::vector<ResourceConfig> resources =
+            discovery->discover_resources(helper.getExtra());
         for (const auto& resource : resources) {
             *response->mutable_resources()->Add() = to_proto(resource);
         }
@@ -33,6 +34,6 @@ ::grpc::Status DiscoveryServer::DoCommand(
     });
 } 
 
-} // namespace impl
-} // namespace sdk
-} // namespace viam
+}  // namespace impl
+}  // namespace sdk
+}  // namespace viam

src/viam/sdk/tests/mocks/mock_discovery.hpp

@@ -21,5 +21,5 @@ class MockDiscovery : public sdk::Discovery {
 
 }  // namespace discovery
 }  // namespace sdktests
-}  // namespace viam 
+}  // namespace viam
 

src/viam/sdk/tests/test_utils.cpp

@@ -28,31 +28,28 @@ std::vector<GeometryConfig> fake_geometries() {
 
 std::vector<ResourceConfig> fake_discovered_resources() {
     return {
-        ResourceConfig(
-            "camera", 
-            "mycam", 
-            "rdk",
-            {{"width", 640}, {"height", 480}, {"format", "mjpeg"}}, 
-            "rdk:component:camera", 
-            "rdk:builtin:webcam"),
-        ResourceConfig(
-            "motor",
-            "arm_motor",
-            "rand",
-            {
-                {"pins", {{"pwm", 18}, {"dir", 23}}},
-                {"max_rpm", 100},
-                {"encoder_steps", 200},
-            }, 
-            "rdk:component:motor",
-            "rand:cool:motor"),
-        ResourceConfig(
-            "sensor",
-            "temp_sensor",
-            "viam",
-            {{"type", "temperature"}, {"unit", "celsius"}, {"poll_rate", 1000}},
-            "rdk:component:sensor",
-            "viam:temp:sensor1"),
+        ResourceConfig( "camera", 
+                        "mycam", 
+                        "rdk",
+                        {{"width", 640}, {"height", 480}, {"format", "mjpeg"}}, 
+                        "rdk:component:camera", 
+                        "rdk:builtin:webcam"),
+        ResourceConfig( "motor",
+                        "arm_motor",
+                        "rand",
+                        {
+                            {"pins", {{"pwm", 18}, {"dir", 23}}},
+                            {"max_rpm", 100},
+                            {"encoder_steps", 200},
+                        }, 
+                        "rdk:component:motor",
+                        "rand:cool:motor"),
+        ResourceConfig( "sensor",
+                        "temp_sensor",
+                        "viam",
+                        {{"type", "temperature"}, {"unit", "celsius"}, {"poll_rate", 1000}},
+                        "rdk:component:sensor",
+                        "viam:temp:sensor1"),
     };
 }