just throw the exception

stuqdog · stuqdog · commit 72c2f8610c87 · 2025-03-04T14:01:15.000-05:00
diff --git a/src/viam/sdk/rpc/dial.cpp b/src/viam/sdk/rpc/dial.cpp
@@ -123,19 +123,18 @@ std::shared_ptr<ViamChannel> ViamChannel::dial_initial(
     }
     opts.set_timeout(opts.initial_connection_attempt_timeout());
 
-    std::exception exception;
-    while (attempts_remaining > 0) {
+    while (attempts_remaining != 0) {
         try {
             auto connection = dial(uri, opts);
             opts.set_timeout(timeout);
             return connection;
         } catch (const std::exception& e) {
             attempts_remaining -= 1;
-            exception = e;
+            if (attempts_remaining == 0) {
+                throw e;
+            }
         }
     }
-
-    throw Exception(ErrorCondition::k_connection, exception.what());
 }
 
 std::shared_ptr<ViamChannel> ViamChannel::dial(const char* uri,

Original file line number	Diff line number	Diff line change
`@@ -123,19 +123,18 @@ std::shared_ptr<ViamChannel> ViamChannel::dial_initial(`
`123`	`123`	`}`
`124`	`124`	`opts.set_timeout(opts.initial_connection_attempt_timeout());`
`125`	`125`
`126`		`- std::exception exception;`
`127`		`- while (attempts_remaining > 0) {`
	`126`	`+ while (attempts_remaining != 0) {`
`128`	`127`	`try {`
`129`	`128`	`auto connection = dial(uri, opts);`
`130`	`129`	`opts.set_timeout(timeout);`
`131`	`130`	`return connection;`
`132`	`131`	`} catch (const std::exception& e) {`
`133`	`132`	`attempts_remaining -= 1;`
`134`		`- exception = e;`
	`133`	`+ if (attempts_remaining == 0) {`
	`134`	`+ throw e;`
	`135`	`+ }`
`135`	`136`	`}`
`136`	`137`	`}`
`137`		`-`
`138`		`- throw Exception(ErrorCondition::k_connection, exception.what());`
`139`	`138`	`}`
`140`	`139`
`141`	`140`	`std::shared_ptr<ViamChannel> ViamChannel::dial(const char* uri,`