silence const warnings

Author: lia-viam

src/viam/sdk/log/logging.cpp

@@ -91,8 +91,8 @@ LogManager& LogManager::get() {
     return result;
 }
 
-void LogManager::set_global_resource_name(std::string name) {
-    sdk_logger_.channel(std::move(name));
+void LogManager::set_global_resource_name(const std::string& name) {
+    sdk_logger_.channel(name);
     VIAM_SDK_LOG(debug) << "Overrode global resource name";
 }
 

src/viam/sdk/log/logging.hpp

@@ -70,7 +70,7 @@ class LogManager {
     static LogManager& get();
 
     /// @brief Override the channel name of general log messages not originating from resources.
-    void set_global_resource_name(std::string);
+    void set_global_resource_name(const std::string& name);
 
     /// @brief Set the global logger severity.
     void set_global_log_level(log_level);