remove

Author: cheukt

src/viam/examples/dial/example_dial.cpp

@@ -46,21 +46,6 @@ int main() {
         std::cout << "\t" << resource << "\n";
     }
 
-    // ensure we can query statuses
-    std::vector<RobotClient::status> status_plural = robot->get_status();
-    std::cout << "Status plural len " << status_plural.size() << std::endl;
-    for (const RobotClient::status& s : status_plural) {
-        std::cout << " Status! " << s.name->api().resource_subtype() << std::endl;
-    }
-
-    // ensure we can send requests for specific resources
-    std::vector<Name> just_one = {resource_names[0]};
-    std::vector<RobotClient::status> status_singular = robot->get_status(just_one);
-    std::cout << "Status singular len " << status_singular.size() << std::endl;
-    for (const RobotClient::status& s : status_singular) {
-        std::cout << " Status! " << s.name->api().resource_subtype() << std::endl;
-    }
-
     // ensure we can create clients to the robot
     auto gc = robot->resource_by_name<GenericComponent>("generic1");
     if (gc) {

src/viam/examples/dial_api_key/example_dial_api_key.cpp

@@ -59,20 +59,5 @@ int main(int argc, char* argv[]) {
         std::cout << "\t" << resource << "\n";
     }
 
-    // ensure we can query statuses
-    std::vector<RobotClient::status> status_plural = robot->get_status();
-    std::cout << "Status plural len " << status_plural.size() << std::endl;
-    for (const RobotClient::status& s : status_plural) {
-        std::cout << " Status! " << s.name->api().resource_subtype() << std::endl;
-    }
-
-    // ensure we can send requests for specific resources
-    std::vector<Name> just_one = {resource_names[0]};
-    std::vector<RobotClient::status> status_singular = robot->get_status(just_one);
-    std::cout << "Status singular len " << status_singular.size() << std::endl;
-    for (const RobotClient::status& s : status_singular) {
-        std::cout << " Status! " << s.name->api().resource_subtype() << std::endl;
-    }
-
     return EXIT_SUCCESS;
 }

src/viam/sdk/robot/client.cpp

@@ -167,37 +167,6 @@ void RobotClient::close() {
 bool is_error_response(const grpc::Status& response) {
     return !response.ok() && (response.error_message() != kStreamRemoved);
 }
-std::vector<RobotClient::status> RobotClient::get_status() {
-    auto resources = resource_names();
-    return get_status(resources);
-}
-// gets statuses of components associated with robot. If a specific component
-// vector is provided, only statuses for the given Names will be
-// returned
-std::vector<RobotClient::status> RobotClient::get_status(std::vector<Name>& components) {
-    viam::robot::v1::GetStatusRequest req;
-    viam::robot::v1::GetStatusResponse resp;
-    ClientContext ctx;
-    for (const Name& name : components) {
-        *req.mutable_resource_names()->Add() = name.to_proto();
-    }
-
-    const grpc::Status response = impl_->stub_->GetStatus(ctx, req, &resp);
-    if (is_error_response(response)) {
-        BOOST_LOG_TRIVIAL(error) << "Error getting status: " << response.error_message()
-                                 << response.error_details();
-    }
-
-    const RepeatedPtrField<Status> resp_status = resp.status();
-
-    std::vector<status> statuses = std::vector<status>();
-
-    for (const Status& s : resp_status) {
-        statuses.push_back(from_proto(s));
-    }
-
-    return statuses;
-}
 
 std::vector<RobotClient::operation> RobotClient::get_operations() {
     const viam::robot::v1::GetOperationsRequest req;

src/viam/sdk/robot/client.hpp

@@ -129,15 +129,6 @@ class RobotClient {
     /// @return The list of operations currently running on the calling robot.
     std::vector<operation> get_operations();
 
-    /// @brief Get the status of the requested robot components.
-    /// @param components A list of the specific components for which status is desired.
-    /// @return A list of statuses.
-    std::vector<status> get_status(std::vector<Name>& components);
-
-    /// @brief Get the status of all robot components.
-    /// @return A list of statuses.
-    std::vector<status> get_status();
-
     std::vector<discovery> discover_components(const std::vector<discovery_query>& queries);
 
     /// @brief Transform a given `Pose` to a new specified destination which is a reference frame.

src/viam/sdk/tests/test_robot.cpp

@@ -108,31 +108,6 @@ BOOST_AUTO_TEST_CASE(test_resource_names) {
         });
 }
 
-BOOST_AUTO_TEST_CASE(test_get_status) {
-    robot_client_to_mocks_pipeline(
-        [](std::shared_ptr<RobotClient> client, MockRobotService& service) -> void {
-            auto mock_statuses = mock_status_response();
-
-            // get all resource statuses
-            auto statuses = client->get_status();
-
-            // ensure we get statuses for all resources, and that they are as expected.
-            BOOST_CHECK_EQUAL(statuses.size(), 3);
-            BOOST_TEST(statuses == mock_statuses, boost::test_tools::per_element());
-
-            // get only a subset of status responses
-            auto names = mock_resource_names_response();
-            std::vector<Name> some_names{names[0], names[1]};
-            auto some_statuses = client->get_status(some_names);
-            // ensure that we only get two of the three existing statuses
-            BOOST_CHECK_EQUAL(some_statuses.size(), 2);
-
-            std::vector<RobotClient::status> some_mock_statuses{mock_statuses[0], mock_statuses[1]};
-
-            BOOST_TEST(some_statuses == some_mock_statuses, boost::test_tools::per_element());
-        });
-}
-
 // This test ensures that the functions in the `mock_robot` files have the same fields for both
 // the proto and custom type versions.
 BOOST_AUTO_TEST_CASE(test_frame_system_config) {