Skip to content

Commit b56ab5c

Browse files
committed
cr comments
1 parent b710c7a commit b56ab5c

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

src/viam/examples/mlmodel/example_audio_classification_client.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ int main(int argc, char* argv[]) try {
377377
});
378378

379379
// Print out the top 5 (or fewer) label/score pairs.
380-
for (size_t i = 0; i != std::min<std::size_t>(5UL, scored_labels.size()); ++i) {
380+
for (size_t i = 0; i != std::min(size_t{5}, scored_labels.size()); ++i) {
381381
// TODO: Avoid hardcoding the width here.
382382
VIAM_SDK_LOG(info) << boost::format("%1%: %2% %|40t|%3%\n") % i %
383383
*scored_labels[i].label % scored_labels[i].score;

src/viam/sdk/CMakeLists.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,9 @@ else()
287287
target_sources(viamsdk PRIVATE rpc/private/viam_rust_utils_stubs.cpp)
288288
endif()
289289

290+
291+
# TODO several of these dependencies should properly be attached to `viam_rust_utils`,
292+
# not `viamsdk`. However, we currently are unable to do so while maintaining compilation
290293
if (APPLE)
291294
target_link_libraries(viamsdk PUBLIC "-framework Security")
292295
elseif (NOT WIN32)

0 commit comments

Comments
 (0)