no smart ptr for thread pool

Author: lia-viam

src/viam/sdk/robot/client.cpp

@@ -290,11 +290,11 @@ std::shared_ptr<RobotClient> RobotClient::with_channel(std::shared_ptr<ViamChann
     robot->refresh_interval_ = options.refresh_interval();
     robot->should_refresh_ = (robot->refresh_interval_ > 0);
     if (robot->should_refresh_) {
-        auto t = std::make_unique<std::thread>(&RobotClient::refresh_every, robot);
+        auto t = std::thread(&RobotClient::refresh_every, robot);
         // TODO(RSDK-1743): this was leaking, confirm that adding thread catching in
         // close/destructor lets us shutdown gracefully. See also address sanitizer,
         // UB sanitizer
-        t->detach();
+        t.detach();
         robot->threads_.push_back(std::move(t));
     };
 

src/viam/sdk/robot/client.hpp

@@ -165,7 +165,7 @@ class RobotClient {
 
     void refresh_every();
 
-    std::vector<std::unique_ptr<std::thread>> threads_;
+    std::vector<std::thread> threads_;
 
     std::atomic<bool> should_refresh_;
     unsigned int refresh_interval_;