Fix lint

Author: hexbabe

src/viam/sdk/components/camera.hpp

@@ -179,7 +179,8 @@ class Camera : public Component {
     /// sources are returned.
     /// @param extra any additional arguments to the method.
     /// @return a vector of raw_images and associated response metadata.
-    virtual image_collection get_images(std::vector<std::string> filter_source_names, const ProtoStruct& extra) = 0;
+    virtual image_collection get_images(std::vector<std::string> filter_source_names,
+                                        const ProtoStruct& extra) = 0;
 
     /// @brief Get the next `point_cloud` from the camera.
     /// @param mime_type the desired mime_type of the point_cloud (does not guarantee output type).

src/viam/sdk/components/private/camera_client.cpp

@@ -126,14 +126,16 @@ Camera::raw_image CameraClient::get_image(std::string mime_type, const ProtoStru
         .invoke([](auto& response) { return from_proto(response); });
 };
 
-Camera::image_collection CameraClient::get_images(std::vector<std::string> filter_source_names, const ProtoStruct& extra) {
-    return make_client_helper(this, *stub_, &StubType::GetImages).with(extra, [&](auto& request) {
-        for (const auto& source_name : filter_source_names) {
-            *request.add_filter_source_names() = source_name;
-        }
-    }).invoke([](auto& response) {
-        return from_proto(response);
-    });
+Camera::image_collection CameraClient::get_images(std::vector<std::string> filter_source_names,
+                                                  const ProtoStruct& extra) {
+    return make_client_helper(this, *stub_, &StubType::GetImages)
+        .with(extra,
+              [&](auto& request) {
+                  for (const auto& source_name : filter_source_names) {
+                      *request.add_filter_source_names() = source_name;
+                  }
+              })
+        .invoke([](auto& response) { return from_proto(response); });
 };
 
 Camera::point_cloud CameraClient::get_point_cloud(std::string mime_type, const ProtoStruct& extra) {

src/viam/sdk/components/private/camera_client.hpp

@@ -26,7 +26,8 @@ class CameraClient : public Camera {
     CameraClient(std::string name, std::shared_ptr<grpc::Channel> channel);
     ProtoStruct do_command(const ProtoStruct& command) override;
     raw_image get_image(std::string mime_type, const ProtoStruct& extra) override;
-    image_collection get_images(std::vector<std::string> filter_source_names, const ProtoStruct& extra) override;
+    image_collection get_images(std::vector<std::string> filter_source_names,
+                                const ProtoStruct& extra) override;
     point_cloud get_point_cloud(std::string mime_type, const ProtoStruct& extra) override;
     properties get_properties() override;
     std::vector<GeometryConfig> get_geometries(const ProtoStruct& extra) override;

src/viam/sdk/components/private/camera_server.cpp

@@ -84,8 +84,9 @@ ::grpc::Status CameraServer::GetImages(
     ::viam::component::camera::v1::GetImagesResponse* response) noexcept {
     return make_service_helper<Camera>(
         "CameraServer::GetImages", this, request)([&](auto& helper, auto& camera) {
-        const Camera::image_collection image_coll =
-            camera->get_images({request->filter_source_names().begin(), request->filter_source_names().end()}, helper.getExtra());
+        const Camera::image_collection image_coll = camera->get_images(
+            {request->filter_source_names().begin(), request->filter_source_names().end()},
+            helper.getExtra());
         for (const auto& img : image_coll.images) {
             ::viam::component::camera::v1::Image proto_image;
             const std::string img_string = bytes_to_string(img.bytes);

src/viam/sdk/tests/mocks/camera_mocks.cpp

@@ -1,5 +1,5 @@
-#include <viam/sdk/tests/mocks/camera_mocks.hpp>
 #include <algorithm>
+#include <viam/sdk/tests/mocks/camera_mocks.hpp>
 
 #include <viam/sdk/common/proto_value.hpp>
 #include <viam/sdk/components/camera.hpp>
@@ -17,7 +17,8 @@ ProtoStruct MockCamera::do_command(const ProtoStruct&) {
 Camera::raw_image MockCamera::get_image(std::string, const ProtoStruct&) {
     return image_;
 }
-Camera::image_collection MockCamera::get_images(std::vector<std::string> filter_source_names, const ProtoStruct& extra) {
+Camera::image_collection MockCamera::get_images(std::vector<std::string> filter_source_names,
+                                                const ProtoStruct& extra) {
     last_filter_source_names_ = std::move(filter_source_names);
     last_extra_ = extra;
     if (last_filter_source_names_.empty()) {
@@ -26,7 +27,9 @@ Camera::image_collection MockCamera::get_images(std::vector<std::string> filter_
     Camera::image_collection filtered = images_;
     filtered.images.clear();
     for (const auto& img : images_.images) {
-        if (std::find(last_filter_source_names_.begin(), last_filter_source_names_.end(), img.source_name) != last_filter_source_names_.end()) {
+        if (std::find(last_filter_source_names_.begin(),
+                      last_filter_source_names_.end(),
+                      img.source_name) != last_filter_source_names_.end()) {
             filtered.images.push_back(img);
         }
     }

src/viam/sdk/tests/mocks/camera_mocks.hpp

@@ -12,15 +12,20 @@ class MockCamera : public Camera {
    public:
     ProtoStruct do_command(const ProtoStruct& command) override;
     raw_image get_image(std::string mime_type, const sdk::ProtoStruct& extra) override;
-    image_collection get_images(std::vector<std::string> filter_source_names, const sdk::ProtoStruct& extra) override;
+    image_collection get_images(std::vector<std::string> filter_source_names,
+                                const sdk::ProtoStruct& extra) override;
     point_cloud get_point_cloud(std::string mime_type, const sdk::ProtoStruct& extra) override;
     std::vector<GeometryConfig> get_geometries(const sdk::ProtoStruct& extra) override;
     properties get_properties() override;
     static std::shared_ptr<MockCamera> get_mock_camera();
     MockCamera(std::string name) : Camera(std::move(name)) {}
 
-    const std::vector<std::string>& last_filter_source_names() const { return last_filter_source_names_; }
-    const ProtoStruct& last_extra() const { return last_extra_; }
+    const std::vector<std::string>& last_filter_source_names() const {
+        return last_filter_source_names_;
+    }
+    const ProtoStruct& last_extra() const {
+        return last_extra_;
+    }
 
    private:
     Camera::intrinsic_parameters intrinsic_parameters_;

src/viam/sdk/tests/test_camera.cpp

@@ -70,16 +70,17 @@ BOOST_AUTO_TEST_CASE(test_get_images_filtering) {
 }
 
 BOOST_AUTO_TEST_CASE(test_get_images_with_extra) {
-    std::shared_ptr<MockCamera> mock = MockCamera::get_mock_camera();
-    client_to_mock_pipeline<Camera>(mock, [&](Camera& client) {
+    SECTION("get_images happy path") {
+        auto mock = MockCamera::get_mock_camera();
+        CameraClient client("camera", std::make_shared<ClientChannel>("camera", "a", mock));
         ProtoStruct extra;
         extra["foo"] = ProtoValue("bar");
         auto images = client.get_images({}, extra);
-        (void)images; // unused variable in test body
+        (void)images;  // unused variable in test body
         const auto& last_extra = mock->last_extra();
         BOOST_CHECK(last_extra.at("foo").is_a<std::string>());
         BOOST_CHECK_EQUAL(last_extra.at("foo").get_unchecked<std::string>(), "bar");
-    });
+    }
 }
 
 BOOST_AUTO_TEST_CASE(test_get_point_cloud) {