make viamapi a private dep of sdk

Author: lia-viam

src/viam/examples/modules/complex/CMakeLists.txt

@@ -106,6 +106,7 @@ target_include_directories(complex_module_sources
 )
 target_link_libraries(complex_module_sources
   viam-cpp-sdk::viamsdk
+  viam-cpp-sdk::viamapi
 )
 
 add_executable(complex_module)

src/viam/sdk/CMakeLists.txt

@@ -15,7 +15,7 @@ add_library(viam-cpp-sdk::viamsdk ALIAS viamsdk)
 # `BASE_DIRS` below, because otherwise we will pull in the static
 # versions of the proto files even if we are generating dynamically.
 target_include_directories(viamsdk
-  PUBLIC
+  PRIVATE
     "$<BUILD_INTERFACE:$<TARGET_PROPERTY:viam-cpp-sdk::viamapi,INTERFACE_INCLUDE_DIRECTORIES>>"
 )
 
@@ -234,9 +234,9 @@ target_link_directories(viamsdk
 )
 
 if (BUILD_SHARED_LIBS)
-  target_link_libraries(viamsdk PUBLIC viam-cpp-sdk::viamapi)
+  target_link_libraries(viamsdk PRIVATE viam-cpp-sdk::viamapi)
 else()
-  target_link_libraries(viamsdk PUBLIC "$<LINK_LIBRARY:WHOLE_ARCHIVE,viam-cpp-sdk::viamapi>")
+  target_link_libraries(viamsdk PRIVATE "$<LINK_LIBRARY:WHOLE_ARCHIVE,viam-cpp-sdk::viamapi>")
 endif()
 
 target_link_libraries(viamsdk

src/viam/sdk/tests/CMakeLists.txt

@@ -39,8 +39,14 @@ target_sources(viamsdk_test
     test_utils.cpp
 )
 
+target_include_directories(viamsdk_test
+  PUBLIC
+    "$<BUILD_INTERFACE:$<TARGET_PROPERTY:viam-cpp-sdk::viamapi,INTERFACE_INCLUDE_DIRECTORIES>>"
+)
+
 target_link_libraries(viamsdk_test
   PUBLIC viam-cpp-sdk::viamsdk
+  PUBLIC viam-cpp-sdk::viamapi
 )
 
 viamcppsdk_add_boost_test(test_arm.cpp)