first review

Author: gabegottlob

src/viam/sdk/CMakeLists.txt

@@ -223,7 +223,7 @@ target_sources(viamsdk
 if(WIN32)
   target_sources(viamsdk
   PRIVATE
-  module/signal_manager_windows.cpp
+    module/signal_manager_windows.cpp
   )
 else()
   target_sources(viamsdk

src/viam/sdk/module/signal_manager.hpp

@@ -1,6 +1,6 @@
 #pragma once
 
-#include <memory>  //must include for std::unique_ptr
+#include <memory> 
 
 namespace viam {
 namespace sdk {
@@ -23,8 +23,8 @@ class SignalManager {
     int wait();
 
    private:
-    struct Impl;                  // Forward declaration for pImpl idiom
-    std::unique_ptr<Impl> pImpl;  // Pointer to the implementation
+    struct Impl;                 
+    std::unique_ptr<Impl> pImpl; 
 };
 
 }  // namespace sdk

src/viam/sdk/module/signal_manager_posix.cpp

@@ -1,9 +1,10 @@
 #include <viam/sdk/module/signal_manager.hpp>
 
-#include <csignal>
 #include <pthread.h>
 #include <signal.h>
 
+#include <csignal>
+
 namespace viam {
 namespace sdk {
 
@@ -18,12 +19,12 @@ SignalManager::SignalManager() : pImpl(std::make_unique<Impl>()) {
     pthread_sigmask(SIG_BLOCK, &(pImpl->sigset_), NULL);
 }
 
-SignalManager::~SignalManager() {}
+SignalManager::~SignalManager() = default;
 
 int SignalManager::wait() {
     int sig = 0;
     return sigwait(&((pImpl->sigset_)), &sig);
 }
 
 }  // namespace sdk
-}  // namespace viam
+}  // namespace viam

src/viam/sdk/module/signal_manager_windows.cpp

@@ -1,7 +1,9 @@
-#include <signal.h>
-#include <viam/sdk/module/signal_manager.hpp>
 #include <windows.h>  //this file assumes WIN32
 
+#include <viam/sdk/module/signal_manager.hpp>
+
+#include <signal.h>
+
 #include <stdexcept>
 
 namespace viam {