cleanup

Author: stuqdog

src/viam/examples/modules/complex/client.cpp

@@ -32,10 +32,10 @@ int main() {
     dial_options.set_allow_insecure_downgrade(true);  // set to false if connecting securely
 
     // Uncomment and fill out your credentials details if connecting securely
-    std::string type = "<your authentication type>";
-    std::string payload = "<your authentication payload>";
-    Credentials credentials(type, payload);
-    dial_options.set_credentials(credentials);
+    // std::string type = "<your authentication type>";
+    // std::string payload = "<your authentication payload>";
+    // Credentials credentials(type, payload);
+    // dial_options.set_credentials(credentials);
 
     boost::optional<DialOptions> opts(dial_options);
     std::string address(uri);

src/viam/examples/modules/complex/gizmo/api.cpp

@@ -24,12 +24,12 @@ API API::traits<Gizmo>::api() {
     return {"viam", "component", "gizmo"};
 }
 
-Gizmo::Gizmo(std::string name) : Component(std::move(name)) {};
+Gizmo::Gizmo(std::string name) : Component(std::move(name)){};
 
 /* Gizmo server methods */
 
 GizmoServer::GizmoServer(std::shared_ptr<ResourceManager> manager)
-    : ResourceServer(std::move(manager)) {};
+    : ResourceServer(std::move(manager)){};
 
 grpc::Status GizmoServer::DoOne(grpc::ServerContext* context,
                                 const DoOneRequest* request,
@@ -170,9 +170,7 @@ grpc::Status GizmoServer::DoTwo(::grpc::ServerContext* context,
 /* Gizmo client methods */
 
 GizmoClient::GizmoClient(std::string name, std::shared_ptr<grpc::Channel> channel)
-    : Gizmo(std::move(name)),
-      stub_(GizmoService::NewStub(channel)),
-      channel_(std::move(channel)) {};
+    : Gizmo(std::move(name)), stub_(GizmoService::NewStub(channel)), channel_(std::move(channel)){};
 
 bool GizmoClient::do_one(std::string arg1) {
     return make_client_helper(this, *stub_, &StubType::DoOne)

src/viam/examples/modules/complex/gizmo/impl.hpp

@@ -14,7 +14,7 @@ using namespace viam::sdk;
 // `validate` method that checks config validity.
 class MyGizmo : public Gizmo, public Reconfigurable {
    public:
-    MyGizmo(std::string name, std::string arg1) : Gizmo(std::move(name)), arg1_(std::move(arg1)) {};
+    MyGizmo(std::string name, std::string arg1) : Gizmo(std::move(name)), arg1_(std::move(arg1)){};
     MyGizmo(const Dependencies& deps, const ResourceConfig& cfg) : Gizmo(cfg.name()) {
         this->reconfigure(deps, cfg);
     };

src/viam/examples/modules/complex/main.cpp

@@ -29,8 +29,6 @@ using namespace viam::sdk;
 int main(int argc, char** argv) {
     Model mybase_model("viam", "base", "mybase");
 
-    std::cout << "registering resource servers\n" << std::flush;
-
     // Make sure to explicity register resources with custom APIs.
     Registry::register_resource_server<GizmoServer>();
     Registry::register_resource_server<SummationServer>();
@@ -57,7 +55,6 @@ int main(int argc, char** argv) {
 
     std::vector<std::shared_ptr<ModelRegistration>> mrs = {mybase_mr, mygizmo_mr, mysummation_mr};
     auto my_mod = std::make_shared<ModuleService>(argc, argv, mrs);
-    std::cout << "we have created the module and gotten ready to serve\n" << std::flush;
     my_mod->serve();
 
     return EXIT_SUCCESS;

src/viam/sdk/common/client_helper.hpp

@@ -35,9 +35,6 @@ class ClientHelper {
     static void default_rsc_(RequestType&) {}
     static void default_rhc_(const ResponseType&) {}
     static void default_ehc_(const ::grpc::Status& status) {
-        std::cout << "error is " << status.error_details() << " " << status.error_code() << " "
-                  << status.error_message() << "\n"
-                  << std::flush;
         throw GRPCException(status);
     }
 

src/viam/sdk/common/logger.cpp

@@ -185,6 +185,8 @@ ValueType set_get_attrib(const char* name, ValueType value) {
 
 void Logger::log(const std::string& msg, log_level level, const char* filename, int line_no) const {
     // in case logging hasn't been initialized, let's set it up.
+    // (RSDK-9172) This should be called from within an initializer object that handles all SDK
+    // initialization for us.
     init_logging();
 
     BOOST_LOG_STREAM_WITH_PARAMS(

src/viam/sdk/common/logger.hpp

@@ -115,7 +115,6 @@ void init_logging(std::ostream& custom_strm);
 
 }  // namespace sdk
 }  // namespace viam
-   //
 
 //  New macro that includes severity, filename and line number
 #define VIAM_SDK_CUSTOM_FORMATTED_LOG(logger, sev, msg) \

src/viam/sdk/components/component.cpp

@@ -14,9 +14,9 @@ namespace sdk {
 
 using viam::common::v1::ResourceName;
 
-Component::Component() : Resource("component") {};
+Component::Component() : Resource("component"){};
 
-Component::Component(std::string name) : Resource(std::move(name)) {};
+Component::Component(std::string name) : Resource(std::move(name)){};
 
 ResourceName Component::get_resource_name(std::string name) const {
     auto r = this->Resource::get_resource_name(name);

src/viam/sdk/config/resource.cpp

@@ -144,8 +144,7 @@ viam::app::v1::ComponentConfig ResourceConfig::to_proto() const {
     return proto_cfg;
 }
 
-ResourceConfig::ResourceConfig(std::string type)
-    : api_({kRDK, type, ""}), type_(std::move(type)) {};
+ResourceConfig::ResourceConfig(std::string type) : api_({kRDK, type, ""}), type_(std::move(type)){};
 
 }  // namespace sdk
 }  // namespace viam

src/viam/sdk/module/handler_map.cpp

@@ -32,7 +32,7 @@ viam::module::v1::HandlerMap HandlerMap_::to_proto() const {
     return proto;
 };
 
-HandlerMap_::HandlerMap_() {};
+HandlerMap_::HandlerMap_(){};
 
 // NOLINTNEXTLINE(readability-const-return-type)
 const HandlerMap_ HandlerMap_::from_proto(const viam::module::v1::HandlerMap& proto) {