global resource is const char*

Author: lia-viam

src/viam/sdk/log/logger.cpp

@@ -63,7 +63,7 @@ std::ostream& operator<<(std::ostream& os, log_level lvl) {
     return os;
 }
 
-std::string global_resource_name() {
+const char* global_resource_name() {
     return "Viam C++ SDK";
 }
 

src/viam/sdk/log/logger.hpp

@@ -48,7 +48,7 @@ using LogSource = boost::log::sources::severity_channel_logger_mt<log_level>;
 
 /// @brief Returns the "channel name" of general log messages not originating from resources.
 /// @ingroup Log
-std::string global_resource_name();
+const char* global_resource_name();
 
 /// @class Logger logger.hpp "log/logger.hpp"
 /// @brief Manages the logging infrastructure in the SDDK.

src/viam/sdk/tests/test_log.cpp

@@ -24,7 +24,7 @@ BOOST_AUTO_TEST_CASE(test_cout_logging) {
     redirect.release();
 
     for (const std::string& s :
-         {"log1"s, to_string(sdk::log_level::info), sdk::global_resource_name()}) {
+         {"log1"s, to_string(sdk::log_level::info), std::string{sdk::global_resource_name()}}) {
         BOOST_CHECK(rec.find(s) != std::string::npos);
     }
 }