pr comments part 1

Author: stuqdog

src/viam/sdk/common/utils.cpp

@@ -127,8 +127,7 @@ std::string random_debug_key() {
 }
 
 AttributeMap debug_map() {
-    auto debug_key = random_debug_key();
-    return debug_map(debug_key);
+    return debug_map(random_debug_key());
 }
 
 AttributeMap debug_map(std::string debug_key) {

src/viam/sdk/common/utils.hpp

@@ -74,11 +74,11 @@ AttributeMap debug_map();
 AttributeMap debug_map(std::string debug_key);
 
 /// @brief Adds @param debug_key for server-side debug logging to @param map
-/// @throws Exception if the debug_key contains invalid (e.g., uppercase )gRPC characters
+/// @throws Exception if the debug_key contains invalid (e.g., uppercase) gRPC characters
 AttributeMap add_debug_entry(AttributeMap&& map, std::string debug_key);
 
 /// @brief Adds @param debug_key for server-side debug logging to @param map
-/// @throws Exception if the debug_key contains invalid (e.g., uppercase )gRPC characters
+/// @throws Exception if the debug_key contains invalid (e.g., uppercase) gRPC characters
 AttributeMap add_debug_entry(AttributeMap map, std::string debug_key);
 
 /// @brief Adds a random key to @param map for server-side debug logging

src/viam/sdk/tests/mocks/mock_motion.cpp

@@ -65,7 +65,7 @@ std::string MockMotion::move_on_globe(
 pose_in_frame MockMotion::get_pose(const Name&,
                                    const std::string&,
                                    const std::vector<WorldState::transform>&,
-                                   const AttributeMap&) {
+                                   const AttributeMap& extra) {
     return current_location;
 }
 

src/viam/sdk/tests/mocks/mock_motion.hpp

@@ -91,6 +91,7 @@ class MockMotion : public sdk::Motion {
     std::string peek_destination_frame;
     double peek_heading;
     bool peek_stop_plan_called = false;
+    std::string peek_debug_key;
     std::vector<sdk::geo_geometry> peek_obstacles;
     std::vector<sdk::GeometryConfig> peek_map_obstacles;
     std::shared_ptr<constraints> peek_constraints;
@@ -99,7 +100,7 @@ class MockMotion : public sdk::Motion {
     std::shared_ptr<sdk::WorldState> peek_world_state;
 
     MockMotion(std::string name)
-        : sdk::Motion(std::move(name)), current_location(init_fake_pose()){};
+        : sdk::Motion(std::move(name)), current_location(init_fake_pose()) {};
 };
 
 }  // namespace motion

src/viam/sdk/tests/test_motion.cpp

@@ -3,6 +3,7 @@
 #include <boost/test/included/unit_test.hpp>
 
 #include <viam/sdk/common/pose.hpp>
+#include <viam/sdk/common/utils.hpp>
 #include <viam/sdk/common/world_state.hpp>
 #include <viam/sdk/services/motion.hpp>
 #include <viam/sdk/spatialmath/geometry.hpp>
@@ -171,6 +172,9 @@ BOOST_AUTO_TEST_CASE(test_move_and_get_pose) {
         std::string destination_frame("destination");
         std::vector<WorldState::transform> transforms;
         AttributeMap extra = fake_map();
+        std::string debug_key = "debug-key";
+        extra = add_debug_entry(extra, debug_key);
+
         pose_in_frame pose = client.get_pose(fake_component_name(), destination_frame, {}, extra);
         BOOST_CHECK_EQUAL(pose, init_fake_pose());