2nd testing

Author: gabegottlob

src/viam/sdk/module/signal_manager.hpp

@@ -1,6 +1,6 @@
 #pragma once
 
-#include <memory> //must include for std::unique_ptr
+#include <memory>  //must include for std::unique_ptr
 
 namespace viam {
 namespace sdk {
@@ -23,8 +23,8 @@ class SignalManager {
     int wait();
 
    private:
-   struct Impl;  // Forward declaration for pImpl idiom
-   std::unique_ptr<Impl> pImpl;  // Pointer to the implementation
+    struct Impl;                  // Forward declaration for pImpl idiom
+    std::unique_ptr<Impl> pImpl;  // Pointer to the implementation
 };
 
 }  // namespace sdk

src/viam/sdk/module/signal_manager_posix.cpp

@@ -1,18 +1,17 @@
 #include <viam/sdk/module/signal_manager.hpp>
 
-#include <signal.h>
 #include <csignal>
 #include <pthread.h>
+#include <signal.h>
 
 namespace viam {
 namespace sdk {
 
 struct SignalManager::Impl {
-    sigset_t sigset_;        
+    sigset_t sigset_;
 };
 
-SignalManager::SignalManager() 
-:pImpl(std::make_unique<Impl>()) {
+SignalManager::SignalManager() : pImpl(std::make_unique<Impl>()) {
     sigemptyset(&(pImpl->sigset_));
     sigaddset(&(pImpl->sigset_), SIGINT);
     sigaddset(&(pImpl->sigset_), SIGTERM);

src/viam/sdk/module/signal_manager_windows.cpp

@@ -1,42 +1,41 @@
+#include <signal.h>
 #include <viam/sdk/module/signal_manager.hpp>
-#include <signal.h>  
-#include <windows.h> //this file assumes WIN32
+#include <windows.h>  //this file assumes WIN32
 
 #include <stdexcept>
 
 namespace viam {
 namespace sdk {
 
-struct SignalManager::Impl { //Windows implementation details of SignalManager
-    static BOOL WINAPI console_handler_routine_(DWORD dwCtrlType){
+struct SignalManager::Impl {  // Windows implementation details of SignalManager
+    static BOOL WINAPI console_handler_routine_(DWORD dwCtrlType) {
         if (dwCtrlType == CTRL_C_EVENT || dwCtrlType == CTRL_BREAK_EVENT) {
-            instance_->handle_signal_(SIGINT);
+            instance_->pImpl->handle_signal_(SIGINT);
             return TRUE;
         } else if (dwCtrlType == CTRL_CLOSE_EVENT || dwCtrlType == CTRL_LOGOFF_EVENT ||
-                dwCtrlType == CTRL_SHUTDOWN_EVENT) {
-            instance_->handle_signal_(SIGTERM);
+                   dwCtrlType == CTRL_SHUTDOWN_EVENT) {
+            instance_->pImpl->handle_signal_(SIGTERM);
             return TRUE;
         }
         return FALSE;
     }
 
-    void handle_signal_(int signal){
+    void handle_signal_(int signal) {
         if (signal_event_ != INVALID_HANDLE_VALUE) {
             signal_code_ = signal;
             SetEvent(signal_event_);
         }
     }
-    
-    static SignalManager::Impl* instance_;
+
+    static SignalManager* instance_;
     HANDLE signal_event_ = INVALID_HANDLE_VALUE;
     int signal_code_ = 0;
 };
 
-SignalManager::Impl* SignalManager::Impl::instance_ = nullptr;
+SignalManager* SignalManager::Impl::instance_ = nullptr;
 
-SignalManager::SignalManager() 
-:pImpl(std::make_unique<Impl>()) {
-    SignalManager::Impl::instance_ = this->pImpl;
+SignalManager::SignalManager() : pImpl(std::make_unique<Impl>()) {
+    SignalManager::Impl::instance_ = this;
     SetConsoleCtrlHandler(SignalManager::Impl::console_handler_routine_, TRUE);
 }
 
@@ -57,6 +56,5 @@ int SignalManager::wait() {
     return static_cast<DWORD>(pImpl->signal_code_);
 }
 
-
 }  // namespace sdk
 }  // namespace viam