Skip to content

Commit fc0869b

Browse files
committed
run clang format
1 parent 0d2725d commit fc0869b

File tree

10 files changed

+166
-173
lines changed

10 files changed

+166
-173
lines changed

src/viam/examples/modules/audioin/client.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1+
#include <fstream>
12
#include <iostream>
23
#include <memory>
34
#include <string>
4-
#include <fstream>
55
#include <vector>
66

77
#include <viam/sdk/common/instance.hpp>
@@ -66,8 +66,8 @@ int main() {
6666
auto chunk_handler = [&](AudioIn::audio_chunk&& chunk) -> bool {
6767
chunk_count++;
6868
VIAM_SDK_LOG(info) << "Received chunk " << chunk_count
69-
<< " - length: " << chunk.audio_data.size()
70-
<< " bytes, timestamp: " << chunk.start_timestamp_ns;
69+
<< " - length: " << chunk.audio_data.size()
70+
<< " bytes, timestamp: " << chunk.start_timestamp_ns;
7171

7272
for (const auto& byte : chunk.audio_data) {
7373
all_audio_data.push_back(static_cast<uint8_t>(byte));

src/viam/examples/modules/audioin/main.cpp

Lines changed: 18 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
1+
#include <chrono>
2+
#include <cmath>
3+
#include <cstring>
14
#include <iostream>
25
#include <memory>
36
#include <sstream>
4-
#include <cmath>
5-
#include <cstring>
67
#include <vector>
7-
#include <chrono>
88

99
#include <viam/sdk/common/exception.hpp>
1010
#include <viam/sdk/common/instance.hpp>
1111
#include <viam/sdk/common/proto_value.hpp>
12-
#include <viam/sdk/components/sensor.hpp>
1312
#include <viam/sdk/components/audio_in.hpp>
13+
#include <viam/sdk/components/sensor.hpp>
1414
#include <viam/sdk/config/resource.hpp>
1515
#include <viam/sdk/log/logging.hpp>
1616
#include <viam/sdk/module/service.hpp>
@@ -39,10 +39,10 @@ class SineWaveAudioIn : public AudioIn, public Reconfigurable {
3939
properties get_properties(const ProtoStruct&) override;
4040

4141
void get_audio(std::string const& codec,
42-
std::function<bool(audio_chunk&& chunk)> const& chunk_handler,
43-
double const& duration_seconds,
44-
int64_t const& previous_timestamp,
45-
const ProtoStruct& extra) override;
42+
std::function<bool(audio_chunk&& chunk)> const& chunk_handler,
43+
double const& duration_seconds,
44+
int64_t const& previous_timestamp,
45+
const ProtoStruct& extra) override;
4646

4747
private:
4848
double frequency_{440.0};
@@ -88,21 +88,19 @@ AudioIn::properties SineWaveAudioIn::get_properties(const ProtoStruct&) {
8888
}
8989

9090
void SineWaveAudioIn::get_audio(std::string const& codec,
91-
std::function<bool(audio_chunk&& chunk)> const& chunk_handler,
92-
double const& duration_seconds,
93-
int64_t const& previous_timestamp,
94-
const ProtoStruct& extra) {
95-
96-
91+
std::function<bool(audio_chunk&& chunk)> const& chunk_handler,
92+
double const& duration_seconds,
93+
int64_t const& previous_timestamp,
94+
const ProtoStruct& extra) {
9795
const int sample_rate = 44100; // 44.1 kHz
98-
const double amplitude = 0.5; // Half volume
99-
const int chunk_size = 1024; // Samples per chunk
96+
const double amplitude = 0.5; // Half volume
97+
const int chunk_size = 1024; // Samples per chunk
10098

10199
int total_samples = static_cast<int>(duration_seconds * sample_rate);
102100
int num_chunks = (total_samples + chunk_size - 1) / chunk_size;
103101

104-
VIAM_RESOURCE_LOG(info) << "Generating sine wave: " << frequency_ << "Hz, "
105-
<< duration_seconds << "s, " << num_chunks << " chunks";
102+
VIAM_RESOURCE_LOG(info) << "Generating sine wave: " << frequency_ << "Hz, " << duration_seconds
103+
<< "s, " << num_chunks << " chunks";
106104

107105
for (int chunk_idx = 0; chunk_idx < num_chunks; ++chunk_idx) {
108106
int samples_in_chunk = std::min(chunk_size, total_samples - (chunk_idx * chunk_size));
@@ -133,8 +131,8 @@ void SineWaveAudioIn::get_audio(std::string const& codec,
133131

134132
// Get current timestamp in nanoseconds
135133
auto now = std::chrono::system_clock::now();
136-
auto nanos = std::chrono::duration_cast<std::chrono::nanoseconds>(
137-
now.time_since_epoch()).count();
134+
auto nanos =
135+
std::chrono::duration_cast<std::chrono::nanoseconds>(now.time_since_epoch()).count();
138136
chunk.start_timestamp_ns = nanos;
139137
chunk.end_timestamp_ns = nanos;
140138
chunk.sequence = chunk_idx;
@@ -154,7 +152,6 @@ int main(int argc, char** argv) try {
154152
// any other C++ SDK objects and stays alive until all Viam C++ SDK objects are destroyed.
155153
Instance inst;
156154

157-
158155
Model sinewave_model("viam", "audio_in", "sinewave");
159156

160157
std::shared_ptr<ModelRegistration> mr = std::make_shared<ModelRegistration>(

src/viam/sdk/components/audio_in.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ AudioIn::AudioIn(std::string name) : Component(std::move(name)) {}
1919

2020
bool operator==(const AudioIn::properties& lhs, const AudioIn::properties& rhs) {
2121
return lhs.supported_codecs == rhs.supported_codecs &&
22-
lhs.sample_rate_hz == rhs.sample_rate_hz &&
23-
lhs.sample_rate_hz == rhs.sample_rate_hz;
22+
lhs.sample_rate_hz == rhs.sample_rate_hz && lhs.sample_rate_hz == rhs.sample_rate_hz;
2423
}
2524

2625
} // namespace sdk

src/viam/sdk/components/audio_in.hpp

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#include <viam/sdk/common/utils.hpp>
1010
#include <viam/sdk/config/resource.hpp>
1111

12-
1312
namespace viam {
1413
namespace sdk {
1514

@@ -22,7 +21,7 @@ namespace sdk {
2221
/// This acts as an abstract parent class to be inherited from by any drivers representing
2322
/// specific AudioIn implementations. This class cannot be used on its own.
2423
class AudioIn : public Component {
25-
public:
24+
public:
2625
/// @struct properties
2726
/// @brief properties of the AudioIn component
2827
struct properties {
@@ -31,7 +30,6 @@ class AudioIn : public Component {
3130
int num_channels;
3231
};
3332

34-
3533
/// @struct audio_info
3634
/// @brief Information about a piece of audio data
3735
struct audio_info {
@@ -41,7 +39,8 @@ class AudioIn : public Component {
4139
};
4240

4341
/// @struct audio_chunk
44-
/// @brief A sequential chunk of audio data with timing information for continuous audio streams.
42+
/// @brief A sequential chunk of audio data with timing information for continuous audio
43+
/// streams.
4544
struct audio_chunk {
4645
std::vector<std::byte> audio_data;
4746
audio_info audio_info;
@@ -55,41 +54,44 @@ class AudioIn : public Component {
5554
/// until completed or cancelled
5655
/// @param codec requested codec of the audio data
5756
/// @param chunk_handler callback function to call when an audio response is received.
58-
/// For an infinite stream this should return true to keep streaming audio and false to indicate that the stream should terminate.
59-
/// The callback function should not be blocking.
57+
/// For an infinite stream this should return true to keep streaming audio and false to indicate
58+
/// that the stream should terminate. The callback function should not be blocking.
6059
/// @param duration_seconds duration of audio stream. If not set, stream duration is indefinite.
61-
/// @param previous_timestamp timestamp to start the audio stream from for continuity between multiple calls. If not set, will stream data
60+
/// @param previous_timestamp timestamp to start the audio stream from for continuity between
61+
/// multiple calls. If not set, will stream data
6262
// starting from the time the request was received by the server.
6363
inline void get_audio(std::string const& codec,
64-
std::function<bool(audio_chunk&& chunk)> const& chunk_handler,
65-
double const& duration_seconds,
66-
int64_t const& previous_timestamp) {
64+
std::function<bool(audio_chunk&& chunk)> const& chunk_handler,
65+
double const& duration_seconds,
66+
int64_t const& previous_timestamp) {
6767
return get_audio(codec, chunk_handler, duration_seconds, previous_timestamp, {});
6868
}
6969

70-
7170
/// @brief Get a stream of audio from the device
7271
/// until completed or cancelled
7372
/// @param codec requested codec of the audio data
7473
/// @param chunk_handler callback function to call when an audio response is received.
75-
/// For an infinite stream this should return true to keep streaming audio and false to indicate that the stream should terminate.
76-
/// The callback function should not be blocking.
74+
/// For an infinite stream this should return true to keep streaming audio and false to indicate
75+
/// that the stream should terminate. The callback function should not be blocking.
7776
/// @param duration_seconds duration of audio stream. If zero, stream duration is indefinite.
78-
/// @param previous_timestamp timestamp to start the audio stream from for continuity between multiple calls. If zero, will stream data
79-
//starting from the time the request was received by the server.
77+
/// @param previous_timestamp timestamp to start the audio stream from for continuity between
78+
/// multiple calls. If zero, will stream data
79+
// starting from the time the request was received by the server.
8080
/// @param extra Any additional arguments to the method
8181
virtual void get_audio(std::string const& codec,
82-
std::function<bool(audio_chunk&& chunk)> const& chunk_handler,
83-
double const& duration_seconds,
84-
int64_t const& previous_timestamp,
85-
const ProtoStruct& extra) = 0;
82+
std::function<bool(audio_chunk&& chunk)> const& chunk_handler,
83+
double const& duration_seconds,
84+
int64_t const& previous_timestamp,
85+
const ProtoStruct& extra) = 0;
8686

87-
/// @brief Returns properties of the audio in device (supported codecs, sample rate, number of channels)
87+
/// @brief Returns properties of the audio in device (supported codecs, sample rate, number of
88+
/// channels)
8889
inline properties get_properties() {
8990
return get_properties({});
9091
}
9192

92-
/// @brief Returns properties of the audio in device (supported codecs, sample rate, number of channels)
93+
/// @brief Returns properties of the audio in device (supported codecs, sample rate, number of
94+
/// channels)
9395
/// @param extra Any additional arguments to the method
9496
virtual properties get_properties(const ProtoStruct& extra) = 0;
9597

@@ -113,16 +115,14 @@ class AudioIn : public Component {
113115

114116
protected:
115117
explicit AudioIn(std::string name);
118+
};
116119

117-
};
118-
119-
template <>
120-
struct API::traits<AudioIn> {
121-
static API api();
122-
};
123-
124-
bool operator==(const AudioIn::properties& lhs, const AudioIn::properties& rhs);
120+
template <>
121+
struct API::traits<AudioIn> {
122+
static API api();
123+
};
125124

126-
} // namespace sdk
127-
} // namespace viam
125+
bool operator==(const AudioIn::properties& lhs, const AudioIn::properties& rhs);
128126

127+
} // namespace sdk
128+
} // namespace viam

src/viam/sdk/components/private/audio_in_client.cpp

Lines changed: 28 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -26,42 +26,39 @@ AudioInClient::AudioInClient(std::string name, std::shared_ptr<grpc::Channel> ch
2626
stub_(viam::component::audioin::v1::AudioInService::NewStub(channel)),
2727
channel_(std::move(channel)) {}
2828

29-
30-
void AudioInClient::get_audio(std::string const& codec,
31-
std::function<bool(audio_chunk&& chunk)> const& chunk_handler,
32-
double const& duration_seconds,
33-
int64_t const& previous_timestamp,
34-
const ProtoStruct& extra) {
29+
void AudioInClient::get_audio(std::string const& codec,
30+
std::function<bool(audio_chunk&& chunk)> const& chunk_handler,
31+
double const& duration_seconds,
32+
int64_t const& previous_timestamp,
33+
const ProtoStruct& extra) {
3534
return make_client_helper(this, *stub_, &StubType::GetAudio)
3635
.with(extra,
3736
[&](auto& request) {
38-
request.set_codec(codec);
39-
request.set_duration_seconds(duration_seconds);
40-
request.set_previous_timestamp_nanoseconds(previous_timestamp);
37+
request.set_codec(codec);
38+
request.set_duration_seconds(duration_seconds);
39+
request.set_previous_timestamp_nanoseconds(previous_timestamp);
4140
})
4241
.invoke_stream([&](auto& response) {
42+
// Create audio_chunk struct from proto response
43+
audio_chunk chunk;
44+
45+
// Convert audio_data from string to std::vector<std::byte>
46+
const std::string& audio_data_str = response.audio().audio_data();
47+
chunk.audio_data.reserve(audio_data_str.size());
48+
for (char c : audio_data_str) {
49+
chunk.audio_data.push_back(static_cast<std::byte>(c));
50+
}
4351

44-
// Create audio_chunk struct from proto response
45-
audio_chunk chunk;
46-
47-
// Convert audio_data from string to std::vector<std::byte>
48-
const std::string& audio_data_str = response.audio().audio_data();
49-
chunk.audio_data.reserve(audio_data_str.size());
50-
for (char c : audio_data_str) {
51-
chunk.audio_data.push_back(static_cast<std::byte>(c));
52-
}
53-
54-
chunk.sequence = response.audio().sequence();
55-
chunk.request_id = response.request_id();
56-
57-
if (response.audio().has_audio_info()) {
58-
chunk.audio_info.codec = response.audio().audio_info().codec();
59-
chunk.audio_info.sample_rate_hz = response.audio().audio_info().sample_rate_hz();
60-
chunk.audio_info.num_channels = response.audio().audio_info().num_channels();
61-
}
62-
return chunk_handler(std::move(chunk));
63-
});
52+
chunk.sequence = response.audio().sequence();
53+
chunk.request_id = response.request_id();
6454

55+
if (response.audio().has_audio_info()) {
56+
chunk.audio_info.codec = response.audio().audio_info().codec();
57+
chunk.audio_info.sample_rate_hz = response.audio().audio_info().sample_rate_hz();
58+
chunk.audio_info.num_channels = response.audio().audio_info().num_channels();
59+
}
60+
return chunk_handler(std::move(chunk));
61+
});
6562
}
6663

6764
AudioIn::properties AudioInClient::get_properties(const ProtoStruct& extra) {
@@ -75,9 +72,8 @@ AudioIn::properties AudioInClient::get_properties(const ProtoStruct& extra) {
7572
codecs.push_back(codec);
7673
}
7774

78-
return properties{std::move(codecs),
79-
response.sample_rate_hz(),
80-
response.num_channels()};
75+
return properties{
76+
std::move(codecs), response.sample_rate_hz(), response.num_channels()};
8177
});
8278
}
8379

src/viam/sdk/components/private/audio_in_client.hpp

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,15 @@ class AudioInClient : public AudioIn {
2121
AudioInClient(std::string name, std::shared_ptr<grpc::Channel> channel);
2222

2323
void get_audio(std::string const& codec,
24-
std::function<bool(audio_chunk&& chunk)> const& chunk_handler,
25-
double const& duration_seconds,
26-
int64_t const& previous_timestamp,
27-
const ProtoStruct& extra) override;
24+
std::function<bool(audio_chunk&& chunk)> const& chunk_handler,
25+
double const& duration_seconds,
26+
int64_t const& previous_timestamp,
27+
const ProtoStruct& extra) override;
2828

2929
properties get_properties(const ProtoStruct& extra) override;
3030
ProtoStruct do_command(const ProtoStruct& command) override;
3131
std::vector<GeometryConfig> get_geometries(const ProtoStruct& extra) override;
3232

33-
3433
// the `extra` param is frequently unnecessary but needs to be supported. Ideally, we'd
3534
// like to live in a world where implementers of derived classes don't need to go out of
3635
// their way to support two versions of a method (an `extra` version and a non-`extra`
@@ -40,12 +39,11 @@ class AudioInClient : public AudioIn {
4039
// that calls the virtual method and passes a `nullptr` by default in place of the `extra`
4140
// param. In order to access these versions of the methods within the client code, however,
4241
// we need to include these `using` lines.
43-
using AudioIn::get_geometries;
4442
using AudioIn::get_audio;
43+
using AudioIn::get_geometries;
4544
using AudioIn::get_properties;
4645

4746
private:
48-
4947
using StubType = viam::component::audioin::v1::AudioInService::StubInterface;
5048
std::unique_ptr<StubType> stub_;
5149
std::shared_ptr<grpc::Channel> channel_;

0 commit comments

Comments
 (0)