address ethan's pr comments

Author: randhid

src/viam/sdk/services/discovery.hpp

@@ -27,7 +27,8 @@ class Discovery : public Service {
    public:
     /// @brief Discover valid viam configuration of resources that are physically
     /// connected to your machine.
-    /// @ingroup Discovery
+    /// @return array of potential viam configurations for hardware physically
+    /// connected to your viam server
     inline std::vector<ResourceConfig> discover_resources() {
         return discover_resources({});
     }

src/viam/sdk/tests/mocks/mock_discovery.cpp

@@ -14,7 +14,7 @@ std::vector<sdk::ResourceConfig> MockDiscovery::discover_resources(const sdk::Pr
 }
 
 ProtoStruct MockDiscovery::do_command(const sdk::ProtoStruct& command) {
-    return ProtoStruct{};
+    return fake_map();
 }
 
 }  // namespace discovery

src/viam/sdk/tests/test_discovery.cpp

@@ -27,8 +27,12 @@ BOOST_AUTO_TEST_CASE(test_discover_resources) {
 BOOST_AUTO_TEST_CASE(test_do_command) {
     auto mock = std::make_shared<MockDiscovery>("mock_discovery");
     client_to_mock_pipeline<Discovery>(mock, [&](Discovery& client) {
-        const auto ret = client.do_command({});
-        BOOST_CHECK_EQUAL(ret.size(), 0);
+        ProtoStruct expected = fake_map();
+
+        ProtoStruct command = fake_map();
+        ProtoStruct result_map = client.do_command(command);
+
+        BOOST_CHECK(result_map.at("test") == expected.at("test"));
     });
 }