Skip to content

Conversation

@abe-winter
Copy link
Member

@abe-winter abe-winter commented Nov 25, 2024

What changed

  • Remove the 'instability' banner from the top of the readme

Why

Guessing we wrote this before we were doing tagged releases; now that we have version numbers, breaking changes are less destructive.

@abe-winter abe-winter requested a review from a team as a code owner November 25, 2024 22:14
@abe-winter abe-winter requested review from acmorrow, lia-viam, purplenicole730 and stuqdog and removed request for a team November 25, 2024 22:14
Copy link
Member

@purplenicole730 purplenicole730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reasoning! The versions making this notice no longer effective makes sense to me, as long as the others agree.

@acmorrow
Copy link
Member

I'm going to remove myself as a reviewer here, as I think this decision should rest with others.

@acmorrow acmorrow removed their request for review November 26, 2024 16:08
@lia-viam
Copy link
Collaborator

let's merge this after I finish the stuff I'm doing with getting API/proto imports out of headers as that's already set to include some breaking changes

@njooma njooma merged commit d9413c9 into main Jan 27, 2025
4 checks passed
@njooma njooma deleted the remove-notice branch January 27, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants