Miscellaneous google header insulation #346
Conversation
| // compiler. You may wish to comment/uncomment the define above as needed, or add the definition | ||
| // with `-D` to the compiler. |
There was a problem hiding this comment.
(q) just to confirm, is this a standard practice we'd expect people to be comfortable with/know how to do? Specifically, the idea (and syntax) of defining the variable for the compiler, and also the fact that we don't care how it's defined just so long as it is defined? I think the latter is probably pretty clear, but for the former I'd definitely be running to the internet to get more advice on how to proceed. That could just be my ignorance though!
There was a problem hiding this comment.
I think so yes! This is CMake's version of Make/autoconf-generated config.h type headers, where a bunch of stuff will be #define'd or commented out.
The default case which I tried to expand on here is that we expect the variable to not be defined, because that corresponds to some pretty ancient grpc versions.
The other thing I tried to expand on was that this is a configured file which will then be installed with make install, so it's possible but a little weird that the user configures it with one version of grpc, does make install, and then later wants to use that installed version with a different grpc version, in which case they can manipulate the macro definitions with commetning/uncommenting or -D to make it work
2 participants
Some easy/minor changes to take google includes out of headers