Skip to content

RSDK-9670: remove RobotService_ #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2025
Merged

RSDK-9670: remove RobotService_ #351

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3577c10
remove RobotService_
lia-viam Jan 7, 2025
53d4893
Merge branch 'main' of github.com:viamrobotics/viam-cpp-sdk into robo…
lia-viam Jan 8, 2025
41d3500
code review: remove unnecessary newlines
lia-viam Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/viam/examples/camera/example_camera.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

#include <viam/sdk/components/camera.hpp>
#include <viam/sdk/robot/client.hpp>
#include <viam/sdk/robot/service.hpp>

Copy link
Member

@stuqdog stuqdog Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) should delete this newline so the viam/sdk imports are grouped together

#include <viam/sdk/rpc/dial.hpp>

int main() {
Expand Down
2 changes: 1 addition & 1 deletion src/viam/examples/dial/example_dial.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

#include <viam/sdk/components/generic.hpp>
#include <viam/sdk/robot/client.hpp>
#include <viam/sdk/robot/service.hpp>

Copy link
Member

@stuqdog stuqdog Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) should delete this newline so the viam/sdk imports are grouped together

#include <viam/sdk/rpc/dial.hpp>

using namespace viam::sdk;
Expand Down
1 change: 0 additions & 1 deletion src/viam/examples/dial_api_key/example_dial_api_key.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include <grpcpp/support/status.h>

#include <viam/sdk/robot/client.hpp>
#include <viam/sdk/robot/service.hpp>
#include <viam/sdk/rpc/dial.hpp>

using namespace viam::sdk;
Expand Down
2 changes: 1 addition & 1 deletion src/viam/examples/modules/complex/client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

#include <viam/sdk/components/motor.hpp>
#include <viam/sdk/robot/client.hpp>
#include <viam/sdk/robot/service.hpp>

Copy link
Member

@stuqdog stuqdog Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) should delete this newline so the viam/sdk imports are grouped together

#include <viam/sdk/rpc/dial.hpp>

#include "gizmo/api.hpp"
Expand Down
2 changes: 1 addition & 1 deletion src/viam/examples/motor/example_motor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

#include <viam/sdk/components/motor.hpp>
#include <viam/sdk/robot/client.hpp>
#include <viam/sdk/robot/service.hpp>

Copy link
Member

@stuqdog stuqdog Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) should delete this newline so the viam/sdk imports are grouped together

#include <viam/sdk/rpc/dial.hpp>

void print_motor_position(std::shared_ptr<viam::sdk::Motor> motor) {
Expand Down
2 changes: 0 additions & 2 deletions src/viam/sdk/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ target_sources(viamsdk
resource/resource_server_base.cpp
resource/stoppable.cpp
robot/client.cpp
robot/service.cpp
rpc/dial.cpp
rpc/server.cpp
rpc/private/viam_grpc_channel.cpp
Expand Down Expand Up @@ -180,7 +179,6 @@ target_sources(viamsdk
../../viam/sdk/resource/resource_server_base.hpp
../../viam/sdk/resource/stoppable.hpp
../../viam/sdk/robot/client.hpp
../../viam/sdk/robot/service.hpp
../../viam/sdk/rpc/dial.hpp
../../viam/sdk/rpc/message_sizes.hpp
../../viam/sdk/rpc/server.hpp
Expand Down
1 change: 0 additions & 1 deletion src/viam/sdk/module/service.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
#include <viam/sdk/resource/resource_manager.hpp>
#include <viam/sdk/resource/stoppable.hpp>
#include <viam/sdk/robot/client.hpp>
#include <viam/sdk/robot/service.hpp>
#include <viam/sdk/rpc/server.hpp>

namespace viam {
Expand Down
152 changes: 0 additions & 152 deletions src/viam/sdk/robot/service.cpp
View file
Open in desktop

This file was deleted.

49 changes: 0 additions & 49 deletions src/viam/sdk/robot/service.hpp
View file
Open in desktop

This file was deleted.

Loading
Loading