[RSDK-10385] Windows signal handling #407
Conversation
lia-viam
left a comment
lia-viam
left a comment
There was a problem hiding this comment.
fine with merging this as is, but i wonder if going forward this may be past a certain threshold of ifdef proliferation where we want to split sources into signal_manager_win32.cpp and signal_manager_posix.cpp
I totally agree. I'm going to file an issue to revisit the signal handler infrastructure, and note both this idea and the idea of connecting it to the instance singleton (where I suspect it belongs). |
|
2 participants
Claude got this one started, I tidied it up a bit. Overall, I'd like to find a better way to do this that integrates with the new
Instancemechanism, but getting something working is currently a higher priority than elegance/consistency. I'm happy to file a follow-up ticket later to do this more gracefully if we can accept this as an interim solution.