RSDK-11289: Fix logic in replace_one #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lia-viam
requested review from
gabegottlob and
stuqdog
and removed request for
a team
lia-viam
changed the title
stuqdog
approved these changes
Jul 14, 2025
Member
stuqdog
left a comment
stuqdog
left a comment
There was a problem hiding this comment.
lgtm though I think we should probably just get rid of the deprecated replace_one if it doesn't work.
| /// @param name The name of the resource to replace. | ||
| /// @param resource The new resource that is replacing the existing one. | ||
| void replace_one(const Name& name, std::shared_ptr<Resource> resource); | ||
| [[deprecated("Use the callback overload as it destroys before constructing")]] void replace_one( |
Member
There was a problem hiding this comment.
I think if this overload doesn't work correctly we should just get rid of it entirely.
🔗 Link your GitHub account to AtlassianTo enable Code Reviewer, please link your GitHub account to your Atlassian account. Click here to connect your accounts This is a one-time setup that takes less than a minute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
third time's the charm? this should finally fix the
always-rebuildlogic inReconfigureResource, making sure that the old resource is destructed before the new one is created. this was causing issues with realsense and would cause issues for any other unique or global resource which has sole ownership of a device, socket, etc.this adds an overload of
replace_onewhich takes a construction callback, bringing the logic closer to that of eg pythonhttps://github.com/viamrobotics/viam-python-sdk/blob/main/src/viam/module/module.py#L253
i marked the old one as deprecated for now but we may just want to remove it entirely
cc @hexbabe @acmorrow