From 79de867efd5d98c5eabe37322c6caada3dd44a8a Mon Sep 17 00:00:00 2001 From: Lia Stratopoulos <167905060+lia-viam@users.noreply.github.com> Date: Thu, 10 Jul 2025 17:04:21 -0400 Subject: [PATCH 1/2] revert calling private setter --- src/viam/sdk/spatialmath/orientation.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/viam/sdk/spatialmath/orientation.cpp b/src/viam/sdk/spatialmath/orientation.cpp index f87c17a36..2079da80c 100644 --- a/src/viam/sdk/spatialmath/orientation.cpp +++ b/src/viam/sdk/spatialmath/orientation.cpp @@ -51,7 +51,6 @@ void to_proto_impl::operator()(const Orientation& self, aa.set_z(a.z); aa.set_theta(a.theta); *orientation.mutable_axis_angles() = std::move(aa); - orientation.set_has_axis_angles(); } void operator()(const orientation_vector& ov) { @@ -61,7 +60,6 @@ void to_proto_impl::operator()(const Orientation& self, ovec.set_z(ov.z); ovec.set_theta(ov.theta); *orientation.mutable_vector_radians() = std::move(ovec); - orientation.set_has_vector_radians(); } void operator()(const orientation_vector_degrees& ovd) { @@ -71,7 +69,6 @@ void to_proto_impl::operator()(const Orientation& self, ovec.set_z(ovd.z); ovec.set_theta(ovd.theta); *orientation.mutable_vector_degrees() = std::move(ovec); - orientation.set_has_vector_degrees(); } void operator()(const euler_angles& ea) { @@ -80,7 +77,6 @@ void to_proto_impl::operator()(const Orientation& self, euler.set_roll(ea.roll); euler.set_yaw(ea.yaw); *orientation.mutable_euler_angles() = std::move(euler); - orientation.set_has_euler_angles(); } void operator()(const quaternion& q) { @@ -90,7 +86,6 @@ void to_proto_impl::operator()(const Orientation& self, quat.set_y(q.y); quat.set_z(q.z); *orientation.mutable_quaternion() = std::move(quat); - orientation.set_has_quaternion(); } app::v1::Orientation& orientation; From 4391c0a4782e79f165737ae82e81ebee8d6ecba2 Mon Sep 17 00:00:00 2001 From: Lia Stratopoulos <167905060+lia-viam@users.noreply.github.com> Date: Tue, 2 Sep 2025 10:18:15 -0400 Subject: [PATCH 2/2] remove brew installs and check version --- .github/workflows/conan.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/conan.yml b/.github/workflows/conan.yml index 8faec125b..6192b4c6b 100644 --- a/.github/workflows/conan.yml +++ b/.github/workflows/conan.yml @@ -58,8 +58,10 @@ jobs: - name: Install dependencies run: | - brew install cmake - brew install python ninja buf + cmake --version + python --version + ninja --version + brew install buf python -m pip install conan - name: Create package @@ -192,7 +194,7 @@ jobs: run: | apt-get install -y software-properties-common apt-add-repository -y 'deb https://archive.debian.org/debian bullseye-backports main' - + apt-get update apt-get -y install cmake