Refactor motor tests to use a spy instead of a custom mock motor (#1067)

Author: njooma

doc/dependency_decisions.yml

@@ -1,64 +1,64 @@
 ---
 - - :permit
   - Apache 2.0
-  - :who: 
-    :why: 
+  - :who:
+    :why:
     :versions: []
     :when: 2022-08-12 14:31:48.226163463 Z
 - - :permit
   - MIT
-  - :who: 
-    :why: 
+  - :who:
+    :why:
     :versions: []
     :when: 2022-08-12 14:31:52.953331422 Z
 - - :permit
   - BSD-3-Clause
-  - :who: 
-    :why: 
+  - :who:
+    :why:
     :versions: []
     :when: 2022-08-15 12:18:01.493210046 Z
 - - :permit
   - BSD
-  - :who: 
-    :why: 
+  - :who:
+    :why:
     :versions: []
     :when: 2022-08-15 12:18:10.367754569 Z
 - - :permit
   - Simplified BSD
-  - :who: 
-    :why: 
+  - :who:
+    :why:
     :versions: []
     :when: 2022-08-15 12:18:30.799597748 Z
 - - :permit
   - ISC License (ISCL)
-  - :who: 
-    :why: 
+  - :who:
+    :why:
     :versions: []
     :when: 2022-08-15 12:30:07.716433134 Z
 - - :license
   - matplotlib-inline
   - BSD-3-Clause
-  - :who: 
-    :why: 'TODO(RSDK-583): why is license finder unable to detect this license automatically?'
+  - :who:
+    :why: "TODO(RSDK-583): why is license finder unable to detect this license automatically?"
     :license_links: https://github.com/ipython/matplotlib-inline/blob/fbf0ab8f2d81993ff8e319a003f58896c77f2443/LICENSE
     :versions: []
     :when: 2022-09-01 18:14:44.253208011 Z
 - - :permit
   - Historical Permission Notice and Disclaimer (HPND)
-  - :who: 
-    :why: 
+  - :who:
+    :why:
     :versions: []
     :when: 2022-09-16 15:36:22.534210576 Z
 - - :permit
   - Python Software Foundation License
-  - :who: 
-    :why: 
+  - :who:
+    :why:
     :versions: []
     :when: 2022-09-16 15:36:35.544888808 Z
 - - :approve
   - protobuf
-  - :who: 
-    :why: 
+  - :who:
+    :why:
     :versions: []
     :when: 2022-11-17 17:47:26.832844000 Z
 - - :permit
@@ -70,7 +70,14 @@
 - - :ignore
   - typing-extensions
   - :who: ethan
-    :why: it's part of python and subject to the same license as the language, see
+    :why:
+      it's part of python and subject to the same license as the language, see
       https://github.com/python/typing_extensions/blob/main/LICENSE
     :versions: []
     :when: 2025-11-17 15:54:33.095491000 Z
+- - :approve
+  - pymongo
+  - :who: njooma
+    :why: Apache 2.0
+    :versions: []
+    :when: 2026-01-07 21:58:05.061701000 Z

pyproject.toml

@@ -17,6 +17,25 @@ dependencies = [
     "typing-extensions>=4.12.2",
     "pymongo>=4.10.1",
 ]
+[dependency-groups]
+dev = [
+	"coverage>=7.6.1",
+	"mypy-protobuf>=3.6.0",
+	"myst-nb<1.0.0; python_version<'3.9'",
+	"myst-nb>=1.0.0; python_version>='3.9'",
+	"nbmake>=1.5.4",
+	"numpy<1.25.0; python_version<'3.9'",
+	"numpy>=1.26.2; python_version>='3.9'",
+	"pillow>=10.4.0",
+	"pyright>=1.1.382.post1",
+	"pytest-asyncio>=0.24.0",
+	"pytest>=8.3.3",
+	"ruff>=0.6.8",
+	"sphinx-autoapi<3.0.0; python_version<'3.9'",
+	"sphinx-autoapi>=3.0.0; python_version>='3.9'",
+	"sphinx-rtd-theme>=2.0.0",
+	"types-pillow>=10.2.0.20240822",
+]
 
 [project.urls]
 Homepage = "https://www.viam.com"
@@ -39,27 +58,6 @@ path = "src/viam/version_metadata.py"
 packages = ["src/viam"]
 artifacts = ["src/viam/rpc/libviam_rust_utils.*"]
 
-[tool.uv]
-dev-dependencies = [
-	"coverage>=7.6.1",
-	"mypy-protobuf>=3.6.0",
-	"myst-nb<1.0.0; python_version<'3.9'",
-	"myst-nb>=1.0.0; python_version>='3.9'",
-	"nbmake>=1.5.4",
-	"numpy<1.25.0; python_version<'3.9'",
-	"numpy>=1.26.2; python_version>='3.9'",
-	"pillow>=10.4.0",
-	"pyright>=1.1.382.post1",
-	"pytest-asyncio>=0.24.0",
-	"pytest-mock>=3.14.0",
-	"pytest>=8.3.3",
-	"ruff>=0.6.8",
-	"sphinx-autoapi<3.0.0; python_version<'3.9'",
-	"sphinx-autoapi>=3.0.0; python_version>='3.9'",
-	"sphinx-rtd-theme>=2.0.0",
-	"types-pillow>=10.2.0.20240822",
-]
-
 [tool.pytest.ini_options]
 addopts = "-ra"
 testpaths = "tests"

tests/mocks/__init__.py

@@ -0,0 +1,32 @@
+import inspect
+from typing import Dict, List, Sequence, Set, Tuple, Union, get_args, get_origin, get_type_hints
+from unittest.mock import AsyncMock, create_autospec
+
+
+def create_mock_subclass(abstract_class):
+    abstracts = getattr(abstract_class, "__abstractmethods__", set())
+
+    namespace = {}
+    for method_name in abstracts:
+        original_method = getattr(abstract_class, method_name)
+
+        if inspect.iscoroutinefunction(original_method):
+            mock = AsyncMock(spec=f"{abstract_class.__name__}.{method_name}")
+            mock.__name__ = method_name
+            mock.__signature__ = inspect.signature(original_method)
+        else:
+            mock = create_autospec(original_method, instance=True)
+
+        namespace[method_name] = mock
+
+    base_methods = [("do_command", {}), ("get_geometries", [])]
+    for method_name, return_value in base_methods:
+        original_method = getattr(abstract_class, method_name, None)
+        if original_method:
+            mock = AsyncMock(spec=f"{abstract_class.__name__}.{method_name}")
+            mock.__name__ = method_name
+            mock.__signature__ = inspect.signature(original_method)
+            mock.return_value = return_value
+            namespace[method_name] = mock
+
+    return type(f"Mock{abstract_class.__name__}", (abstract_class,), namespace)