Skip to content

Commit 8bfe815

Browse files
change to api in tests, docs, and examples
1 parent 6c1fe7a commit 8bfe815

File tree

11 files changed

+14
-14
lines changed

11 files changed

+14
-14
lines changed

docs/examples/module_step2.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ async def close(self):
3535

3636

3737
async def main():
38-
Registry.register_resource_creator(Sensor.SUBTYPE, MySensor.MODEL, ResourceCreatorRegistration(MySensor.new))
38+
Registry.register_resource_creator(Sensor.API, MySensor.MODEL, ResourceCreatorRegistration(MySensor.new))
3939

4040

4141
if __name__ == "__main__":

docs/examples/module_step2_optional.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ async def close(self):
5757

5858

5959
async def main():
60-
Registry.register_resource_creator(Sensor.SUBTYPE, MySensor.MODEL, ResourceCreatorRegistration(MySensor.new, MySensor.validate_config))
60+
Registry.register_resource_creator(Sensor.API, MySensor.MODEL, ResourceCreatorRegistration(MySensor.new, MySensor.validate_config))
6161

6262

6363
if __name__ == "__main__":

docs/examples/module_step3.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ async def main():
4040
This function creates and starts a new module, after adding all desired resource model.
4141
Resource creators must be registered to the resource registry before the module adds the resource model.
4242
"""
43-
Registry.register_resource_creator(Sensor.SUBTYPE, MySensor.MODEL, ResourceCreatorRegistration(MySensor.new))
43+
Registry.register_resource_creator(Sensor.API, MySensor.MODEL, ResourceCreatorRegistration(MySensor.new))
4444

4545
module = Module.from_args()
4646
module.add_model_from_registry(Sensor.API, MySensor.MODEL)

examples/complex_module/src/arm/my_arm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,4 +115,4 @@ async def close(self):
115115
LOGGER.info(f"{self.name} is closed.")
116116

117117

118-
Registry.register_resource_creator(Arm.SUBTYPE, MyArm.MODEL, ResourceCreatorRegistration(MyArm.new))
118+
Registry.register_resource_creator(Arm.API, MyArm.MODEL, ResourceCreatorRegistration(MyArm.new))

examples/complex_module/src/base/my_base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,4 +147,4 @@ async def get_geometries(self) -> List[Geometry]:
147147
raise NotImplementedError()
148148

149149

150-
Registry.register_resource_creator(Base.SUBTYPE, MyBase.MODEL, ResourceCreatorRegistration(MyBase.new, MyBase.validate_config))
150+
Registry.register_resource_creator(Base.API, MyBase.MODEL, ResourceCreatorRegistration(MyBase.new, MyBase.validate_config))

examples/complex_module/src/gizmo/my_gizmo.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,4 +79,4 @@ async def close(self):
7979
LOGGER.info(f"{self.name} is closed.")
8080

8181

82-
Registry.register_resource_creator(Gizmo.SUBTYPE, MyGizmo.MODEL, ResourceCreatorRegistration(MyGizmo.new, MyGizmo.validate_config))
82+
Registry.register_resource_creator(Gizmo.API, MyGizmo.MODEL, ResourceCreatorRegistration(MyGizmo.new, MyGizmo.validate_config))

examples/complex_module/src/summation/my_summation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,4 +45,4 @@ def reconfigure(self, config: ComponentConfig, dependencies: Mapping[ResourceNam
4545
self.subtract = config.attributes.fields["subtract"].bool_value or False
4646

4747

48-
Registry.register_resource_creator(SummationService.SUBTYPE, MySummationService.MODEL, ResourceCreatorRegistration(MySummationService.new))
48+
Registry.register_resource_creator(SummationService.API, MySummationService.MODEL, ResourceCreatorRegistration(MySummationService.new))

examples/simple_module/src/main.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ async def main():
6363
"""This function creates and starts a new module, after adding all desired resource models.
6464
Resource creators must be registered to the resource registry before the module adds the resource model.
6565
"""
66-
Registry.register_resource_creator(Sensor.SUBTYPE, MySensor.MODEL, ResourceCreatorRegistration(MySensor.new, MySensor.validate_config))
66+
Registry.register_resource_creator(Sensor.API, MySensor.MODEL, ResourceCreatorRegistration(MySensor.new, MySensor.validate_config))
6767

6868
module = Module.from_args()
6969
module.add_model_from_registry(Sensor.API, MySensor.MODEL)

src/viam/resource/registry.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,19 +95,19 @@ def register_api(cls, registration: ResourceRegistration[Resource]):
9595
raise ValidationError("Passed resource registration does not have correct parameters")
9696

9797
@classmethod
98-
def register_resource_creator(cls, subtype: "API", model: "Model", registration: ResourceCreatorRegistration):
98+
def register_resource_creator(cls, api: "API", model: "Model", registration: ResourceCreatorRegistration):
9999
"""Register a specific ``Model`` and validator function for the specific resource ``Subtype`` with the Registry
100100
101101
Args:
102-
subtype (Subtype): The Subtype of the resource
102+
api (API): The API of the resource
103103
model (Model): The Model of the resource
104104
registration (ResourceCreatorRegistration): The registration functions of the model
105105
106106
Raises:
107-
DuplicateResourceError: Raised if the Subtype and Model pairing is already registered
107+
DuplicateResourceError: Raised if the API and Model pairing is already registered
108108
ValidationError: Raised if registration does not have creator
109109
"""
110-
key = f"{subtype}/{model}"
110+
key = f"{api}/{model}"
111111
with cls._lock:
112112
if key in cls._RESOURCES:
113113
raise DuplicateResourceError(key)

tests/mocks/module/gizmo/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@
66

77
Registry.register_api(ResourceRegistration(Gizmo, GizmoService, lambda name, channel: GizmoClient(name, channel)))
88

9-
Registry.register_resource_creator(Gizmo.SUBTYPE, MyGizmo.MODEL, ResourceCreatorRegistration(MyGizmo.new, MyGizmo.validate_config))
9+
Registry.register_resource_creator(Gizmo.API, MyGizmo.MODEL, ResourceCreatorRegistration(MyGizmo.new, MyGizmo.validate_config))

0 commit comments

Comments
 (0)