additionally encode SKU

sprankhub · sprankhub · commit 0cd0317596e1 · 2014-09-29T16:13:53.000+02:00
diff --git a/app/code/community/PiwikMage/PiwikAnalytics/Block/Piwik.php b/app/code/community/PiwikMage/PiwikAnalytics/Block/Piwik.php
@@ -114,7 +114,7 @@ protected function _getEcommerceCartUpdate()
                 continue;
             endif;
 
-            echo "_paq.push(['addEcommerceItem', '" . $cartItem->getSku() . "', " . json_encode($productName) . ", " . json_encode($categoryName) . ", " . $cartItem->getPrice() . ", " . $cartItem->getQty() . "]);";
+            echo "_paq.push(['addEcommerceItem', " . json_encode($cartItem->getSku()) . ", " . json_encode($productName) . ", " . json_encode($categoryName) . ", " . $cartItem->getPrice() . ", " . $cartItem->getQty() . "]);";
             echo "\n";
         }
 
@@ -150,7 +150,7 @@ protected function _getProductPageview()
         $categoryName = $category->getName();
         $productName = $currentProduct->getName();
 
-        echo "_paq.push(['setEcommerceView', '" . $currentProduct->getSku() . "', " . json_encode($productName) . ", " . json_encode($categoryName) . ", " . $currentProduct->getPrice() . " ]);";
+        echo "_paq.push(['setEcommerceView', " . json_encode($currentProduct->getSku()) . ", " . json_encode($productName) . ", " . json_encode($categoryName) . ", " . $currentProduct->getPrice() . " ]);";
         Mage::unregister('current_category');
     }
 

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ protected function _getEcommerceCartUpdate()`
`114`	`114`	`continue;`
`115`	`115`	`endif;`
`116`	`116`
`117`		`- echo "_paq.push(['addEcommerceItem', '" . $cartItem->getSku() . "', " . json_encode($productName) . ", " . json_encode($categoryName) . ", " . $cartItem->getPrice() . ", " . $cartItem->getQty() . "]);";`
	`117`	`+ echo "_paq.push(['addEcommerceItem', " . json_encode($cartItem->getSku()) . ", " . json_encode($productName) . ", " . json_encode($categoryName) . ", " . $cartItem->getPrice() . ", " . $cartItem->getQty() . "]);";`
`118`	`118`	`echo "\n";`
`119`	`119`	`}`
`120`	`120`
`@@ -150,7 +150,7 @@ protected function _getProductPageview()`
`150`	`150`	`$categoryName = $category->getName();`
`151`	`151`	`$productName = $currentProduct->getName();`
`152`	`152`
`153`		`- echo "_paq.push(['setEcommerceView', '" . $currentProduct->getSku() . "', " . json_encode($productName) . ", " . json_encode($categoryName) . ", " . $currentProduct->getPrice() . " ]);";`
	`153`	`+ echo "_paq.push(['setEcommerceView', " . json_encode($currentProduct->getSku()) . ", " . json_encode($productName) . ", " . json_encode($categoryName) . ", " . $currentProduct->getPrice() . " ]);";`
`154`	`154`	`Mage::unregister('current_category');`
`155`	`155`	`}`
`156`	`156`