Skip to content

Review Bets #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lastperson wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Review Bets #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions contracts/Bets.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ contract Bets {
}

function searchGame(string descr) constant returns (uint index) {
// What if there is millions of games? Maybe searches should take constant time whenever possible.
for (var i=0; i<numGames; i++){
if (sha3(games[i].description) == sha3(descr)) {
return i;
Expand All @@ -73,6 +74,7 @@ contract Bets {
}

function placeBet(uint GameID, string Case) onlyNotAdmin() payable returns (bool result){
// What if user sent ETH to inactive game? It will just sit here unnoticed.
if (! games[GameID].isActive) return false;
if ((sha3(Case) == sha3("A")) || (sha3(Case) == sha3("a")))
games[GameID].bets[games[GameID].numBets].betCase = "A";
Expand Down Expand Up @@ -103,19 +105,24 @@ contract Bets {
}
else return false;
games[GameID].isActive = false;
// What if there is a million of bets? This loop will never have enough gas.
for (i=0; i<games[GameID].numBets; i++)
if (sha3(games[GameID].bets[i].betCase) == sha3(games[GameID].winner))
sumWinners += games[GameID].bets[i].amount;
else sumLosers += games[GameID].bets[i].amount;
if (sumWinners == 0) {
// If send to admin failed, then this game's ETH will be locked forever, cause game inactive now.
if(!admin.send(sumLosers)){ return false; }
}
else {
adminFee = sumLosers/10;
rate = (sumLosers-adminFee)*1000/sumWinners;
// If send to admin failed, then this game's ETH will be locked forever, cause game inactive now.
if(!admin.send(adminFee)){ return false; }
// What if there is a million of bets? This loop will never have enough gas.
for (i=0; i<games[GameID].numBets; i++){
if (sha3(games[GameID].bets[i].betCase) == sha3(games[GameID].winner))
// If send to bettor failed, then this game's ETH will be locked forever, cause game inactive now.
if(!games[GameID].bets[i].bettor.send(
rate*(games[GameID].bets[i].amount)/1000+games[GameID].bets[i].amount))
{return false;}
Expand Down