fix: resolve all remaining eslint errors (76 → 0)

dannyshmueli · claude · dannyshmueli · commit ca511e604749 · 2025-12-06T21:36:11.000+02:00
- Convert all require() to ES imports for package.json, fs, os, path - Fix async Promise executor in interactive-menu.ts - Add eslint-disable for intentional control character regex patterns 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/src/commands/send.ts b/src/commands/send.ts
@@ -1,21 +1,25 @@
-import { SendOrchestrator, SendOptions } from '../lib/orchestrators/send-orchestrator';
+import chalk from 'chalk';
+import { execSync } from 'child_process';
+import { promises as fs } from 'fs';
+import os from 'os';
+import path from 'path';
+import packageJson from '../../package.json';
+import { isNetworkError, createNetworkError } from '../lib/errors/network-errors';
 import { BackgroundSendOrchestrator } from '../lib/orchestrators/background-send-orchestrator';
 import { HookSendOrchestrator } from '../lib/orchestrators/hook-send-orchestrator';
-import { SendProgressUI } from '../lib/ui/send/send-progress';
-import { SendSummaryUI } from '../lib/ui/send/send-summary';
-import { SendConfirmationUI } from '../lib/ui/send/send-confirmation';
+import { SendOrchestrator, SendOptions } from '../lib/orchestrators/send-orchestrator';
 import { showPrivacyPreview } from '../lib/ui/privacy-preview';
 import { parseProjectName } from '../lib/ui/project-display';
 import { countTotalRedactions } from '../lib/ui/sanitization-display';
+import { SendConfirmationUI } from '../lib/ui/send/send-confirmation';
+import { SendProgressUI } from '../lib/ui/send/send-progress';
+import { SendSummaryUI } from '../lib/ui/send/send-summary';
 import { showUploadResults } from '../lib/ui';
 import { VibelogError } from '../utils/errors';
 import { logger } from '../utils/logger';
-import { isNetworkError, createNetworkError } from '../lib/errors/network-errors';
-import { checkForUpdate, shouldSpawnLatestForHook, VersionCheckResult } from '../utils/version-check';
-import { tryAcquireUpdateLock, UpdateLock } from '../utils/update-lock';
 import { clearNpxCache, checkNpxCacheHealth } from '../utils/npx-cache';
-import { execSync } from 'child_process';
-import chalk from 'chalk';
+import { tryAcquireUpdateLock, UpdateLock } from '../utils/update-lock';
+import { checkForUpdate, shouldSpawnLatestForHook, VersionCheckResult } from '../utils/version-check';
 
 /**
  * Send session data to Vibelog API
@@ -44,7 +48,7 @@ export async function send(options: SendOptions): Promise<void> {
     // When triggered by hooks, check for updates but don't block session processing.
     // Updates happen in background while current version continues processing.
     if (options.hookTrigger && !process.env.VIBE_LOG_SKIP_UPDATE) {
-      const currentVersion = process.env.SIMULATE_OLD_VERSION || require('../../package.json').version;
+      const currentVersion = process.env.SIMULATE_OLD_VERSION || packageJson.version;
       logger.debug(`Checking version update: hookTrigger=${options.hookTrigger}, currentVersion=${currentVersion}`);
 
       const versionCheck = await checkForUpdate(currentVersion);
@@ -378,10 +382,6 @@ async function updateInBackground(
  * Log update events to update log file
  */
 async function logUpdateEvent(message: string): Promise<void> {
-  const fs = require('fs').promises;
-  const path = require('path');
-  const os = require('os');
-
   const updateLogPath = path.join(os.homedir(), '.vibe-log', 'update.log');
   const timestamp = new Date().toISOString();
   const logLine = `[${timestamp}] ${message}\n`;
diff --git a/src/lib/api-client.ts b/src/lib/api-client.ts
@@ -1,12 +1,13 @@
 import axios, { AxiosInstance, AxiosError } from 'axios';
+import crypto from 'crypto';
+import packageJson from '../../package.json';
+import { claudeSettingsManager } from './claude-settings-manager';
 import { getToken, getApiUrl, getStatusLinePersonality } from './config';
-import { VibelogError } from '../utils/errors';
-import { validateUrl } from './input-validator';
-import { logger } from '../utils/logger';
 import { isNetworkError, createNetworkError } from './errors/network-errors';
-import { claudeSettingsManager } from './claude-settings-manager';
-import crypto from 'crypto';
+import { validateUrl } from './input-validator';
 import type { CliTelemetry } from './telemetry';
+import { VibelogError } from '../utils/errors';
+import { logger } from '../utils/logger';
 
 export interface Session {
   tool: 'claude_code' | 'cursor' | 'vscode';
@@ -98,7 +99,7 @@ async function gatherCLIConfiguration(origin?: string): Promise<CLIConfiguration
     const featureStatus = await claudeSettingsManager.getFeatureStatus();
 
     return {
-      version: require('../../package.json').version,
+      version: packageJson.version,
       origin: origin || null,  // No fallback - must be explicitly set
       statusline: {
         personality: statuslineConfig.personality,
@@ -128,7 +129,7 @@ class SecureApiClient {
       timeout: 30000,
       headers: {
         'Content-Type': 'application/json',
-        'User-Agent': `vibe-log-CLI/${require('../../package.json').version}`,
+        'User-Agent': `vibe-log-CLI/${packageJson.version}`,
         'X-Client-Version': '1.0.0',
       },
       // Prevent automatic redirects to avoid SSRF
diff --git a/src/lib/auth/browser.ts b/src/lib/auth/browser.ts
@@ -321,12 +321,14 @@ function isValidTokenFormat(token: string): boolean {
   }
   
   // Check for common injection patterns
+  /* eslint-disable no-control-regex */
   const dangerousPatterns = [
     /[<>]/,           // HTML injection
     /[`${}]/,         // Template injection
-    /[\u0000-\u001F]/,    // Control characters  eslint-disable-line no-control-regex
+    /[\u0000-\u001F]/,    // Control characters
     /['";\\]/,        // SQL/Command injection
   ];
+  /* eslint-enable no-control-regex */
   
   return !dangerousPatterns.some(pattern => pattern.test(token));
 }
diff --git a/src/lib/input-validator.ts b/src/lib/input-validator.ts
@@ -219,12 +219,14 @@ export function validateAuthToken(token: string): string {
   }
   
   // Check for common injection patterns
+  /* eslint-disable no-control-regex */
   const dangerousPatterns = [
     /[<>]/,           // HTML injection
     /[`${}]/,         // Template injection
-    /[\u0000-\u001F]/,    // Control characters  eslint-disable-line no-control-regex
+    /[\u0000-\u001F]/,    // Control characters
     /[';\\]/,         // SQL/Command injection
   ];
+  /* eslint-enable no-control-regex */
   
   for (const pattern of dangerousPatterns) {
     if (pattern.test(trimmed)) {
diff --git a/src/lib/telemetry.ts b/src/lib/telemetry.ts
@@ -1,10 +1,9 @@
+import packageJson from '../../package.json';
 import { getToken, getStatusLinePersonality } from './config';
 import { detectSetupState } from './detector';
 import { getHooksStatus } from './hooks/hooks-controller';
 import { logger } from '../utils/logger';
 
-const pkg = require('../../package.json');
-
 export interface CliTelemetry {
   // Installation state
   hooksInstalled: boolean;
@@ -43,7 +42,7 @@ export async function collectTelemetry(): Promise<CliTelemetry | null> {
     trackedProjectCount: state.trackedProjectCount,
     statusLineInstalled: state.hasStatusLine,
     statusLinePersonality: statusLine?.personality || 'gordon',
-    cliVersion: pkg.version,
+    cliVersion: packageJson.version,
     hookVersion: hookStatus.sessionStartHook?.version || hookStatus.preCompactHook?.version, // Deprecated
     sessionStartHookVersion: hookStatus.sessionStartHook?.version,
     preCompactHookVersion: hookStatus.preCompactHook?.version,
diff --git a/src/lib/ui/first-time-welcome.ts b/src/lib/ui/first-time-welcome.ts
@@ -1,6 +1,7 @@
+import chalk from 'chalk';
 import inquirer from 'inquirer';
+import packageJson from '../../../package.json';
 import { colors } from './styles';
-import chalk from 'chalk';
 import { InteractiveMenu, MenuOption } from './interactive-menu';
 
 export type WelcomeChoice = 'standup' | 'local' | 'cloud' | 'statusline' | 'exit';
@@ -80,8 +81,7 @@ export async function showFirstTimeWelcome(): Promise<WelcomeChoice> {
 
       // Show logo and slogan
       const { showLogo } = await import('../ui');
-      const pkg = require('../../../package.json');
-      const version = process.env.SIMULATE_OLD_VERSION || pkg.version;
+      const version = process.env.SIMULATE_OLD_VERSION || packageJson.version;
       await showLogo(version);
 
       console.log();
diff --git a/src/lib/ui/interactive-menu.ts b/src/lib/ui/interactive-menu.ts
@@ -1,5 +1,6 @@
-import readline from 'readline';
 import chalk from 'chalk';
+import readline from 'readline';
+import packageJson from '../../../package.json';
 import { colors } from './styles';
 
 export interface MenuOption {
@@ -39,8 +40,7 @@ export class InteractiveMenu {
 
     // Show logo first
     const { showLogo } = await import('../ui');
-    const pkg = require('../../../package.json');
-    const version = process.env.SIMULATE_OLD_VERSION || pkg.version;
+    const version = process.env.SIMULATE_OLD_VERSION || packageJson.version;
     await showLogo(version);
 
     // Slogan as single line, left-aligned
@@ -75,9 +75,9 @@ export class InteractiveMenu {
   }
 
   async show(): Promise<string | null> {
-    return new Promise(async (resolve) => {
-      await this.render();
+    await this.render();
 
+    return new Promise((resolve) => {
       const handleKeypress = async (_str: string | undefined, key: any) => {
         if (key) {
           if (key.name === 'up') {

Original file line number	Diff line number	Diff line change
`@@ -321,12 +321,14 @@ function isValidTokenFormat(token: string): boolean {`
`321`	`321`	`}`
`322`	`322`
`323`	`323`	`// Check for common injection patterns`
	`324`	`+ /* eslint-disable no-control-regex */`
`324`	`325`	`const dangerousPatterns = [`
`325`	`326`	`/[<>]/, // HTML injection`
`326`	`327`	/[`${}]/, // Template injection
`327`		`- /[\u0000-\u001F]/, // Control characters eslint-disable-line no-control-regex`
	`328`	`+ /[\u0000-\u001F]/, // Control characters`
`328`	`329`	`/['";\\]/, // SQL/Command injection`
`329`	`330`	`];`
	`331`	`+ /* eslint-enable no-control-regex */`
`330`	`332`
`331`	`333`	`return !dangerousPatterns.some(pattern => pattern.test(token));`
`332`	`334`	`}`