Adding test cases and code coverage

* Added 401 test cases

* Handled secret callback error

* Updating errorhandler for prod env

* Removed unecessary code

Author: vibhasfl

server/config/errorHandler.js

@@ -10,7 +10,7 @@ const log = debug('app')
 const errorHandler = (err, req, res, next) => {
   log(err)
 
-  if (err instanceof AppError) return res.status(err.status).json({ error: err.message, stack: process.env.APP_ENVIROMENT === 'dev' ? err.stack : '' })
+  if (err instanceof AppError) return res.status(err.status).json({ error: err.message, stack: process.env.APP_ENVIROMENT === 'dev' ? err.stack : undefined })
 
   if (err.name === 'UnauthorizedError') return res.status(httpStatus.UNAUTHORIZED).json({ error: err.message })
 

server/modules/users/users.controller.js

@@ -13,12 +13,6 @@ users.create = async (req, res) => {
   return res.status(httpStatus.CREATED).json({ data: { user } })
 }
 
-users.getUserById = async (req, res) => {
-  let data = await userModel.findOne({ _id: req.params.id }).lean()
-  let { password, __v, ...user } = data
-  return res.json({ data: { user } })
-}
-
 users.update = async (req, res) => {
   let user = await userModel.findById(req.params.id)
   if (!user) return res.status(httpStatus.BAD_REQUEST).json({ message: 'User not found' })

server/utils/secretCallback.js

@@ -1,14 +1,13 @@
 import { userModel } from '../modules/users/user.model'
+import { httpStatus } from '../utils/httpStatus'
+import { AppError } from '../utils/appError'
 
 export const secretCallback = function (req, payload, done) {
   let sub = payload.sub
 
   userModel.findById(sub, function (err, user) {
-    if (err) {
-      return done(err)
-    }
-    if (!user) {
-      return done(new Error('missing_secret'))
+    if (err || !user) {
+      return done(new AppError('Invalid user', httpStatus.UNAUTHORIZED))
     }
     return done(null, user.secret)
   })

test/integration/app.test.js

@@ -79,7 +79,10 @@ describe('GET /auth/profile', () => {
     expect(response).to.have.status(401)
   })
 
-  after('Cleaning users collection', async function () {
+  it('should return 401 invalid user', async () => {
     await userModel.findOneAndDelete({ _id: sampleuserid })
+    let response = await chai.request(server).get(`/api/auth/profile`).set('Authorization', `Bearer ${token}`).send()
+    expect(response).to.have.status(401)
+    expect(response.body.error).to.be.equal('Invalid user')
   })
 })