refactor: move local storage route in its own router

Author: aurelleb

extra/Caddyfile

@@ -0,0 +1,58 @@
+# Caddyfile for Vicinae Extension Store
+# Caddy automatically provisions and renews SSL certificates via Let's Encrypt
+
+{$DOMAIN} {
+	# Enable compression
+	encode gzip zstd
+
+	# Reverse proxy to Hono app
+	reverse_proxy app:3000 {
+		# Health check
+		health_uri /
+		health_interval 30s
+		health_timeout 5s
+
+		# Headers
+		header_up X-Real-IP {remote_host}
+		header_up X-Forwarded-For {remote_host}
+		header_up X-Forwarded-Proto {scheme}
+	}
+
+	# Security headers
+	header {
+		# Remove server header
+		-Server
+
+		# Security headers
+		X-Content-Type-Options "nosniff"
+		X-Frame-Options "DENY"
+		Referrer-Policy "strict-origin-when-cross-origin"
+
+		# CORS headers for extension downloads
+		Access-Control-Allow-Origin "*"
+		Access-Control-Allow-Methods "GET, POST, OPTIONS"
+		Access-Control-Allow-Headers "Content-Type, Authorization"
+	}
+
+	# Rate limiting for uploads (100 requests per minute)
+	rate_limit {
+		zone upload {
+			key {remote_host}
+			events 100
+			window 1m
+		}
+
+		match {
+			path /extension/upload
+		}
+	}
+
+	# Logging
+	log {
+		output file /data/access.log {
+			roll_size 100mb
+			roll_keep 5
+		}
+		format json
+	}
+}

vicinae-store.service extra/vicinae.servicevicinae-store.service renamed to extra/vicinae.service

@@ -1,5 +1,5 @@
 [Unit]
-Description=Vicinae Extension Store API
+Description=Vicinae Backend
 After=network.target
 Documentation=https://github.com/vicinaehq/store
 

src/index.ts

@@ -1,69 +1,25 @@
 import { Hono } from 'hono'
-import { createStorageFromEnv } from './storage/index.js'
-import type { StorageAdapter } from './storage/index.js'
-import { LocalStorageAdapter } from './storage/index.js'
+import type { AppContext } from './types/app.js';
+import { createStorageFromEnv, LocalStorageAdapter, type StorageAdapter } from './storage/index.js'
 import extensionsRouter from './routes/extensions.js'
-import { getMimeType } from './utils/mime.js'
-
-const storage = createStorageFromEnv()
-
-type AppContext = {
-  Variables: {
-    storage: StorageAdapter
-  }
-}
+import localStorageRouter from './routes/storage.js'
 
 const app = new Hono<AppContext>()
+const storage = createStorageFromEnv();
 
 app.use('*', async (c, next) => {
   c.set('storage', storage)
   await next()
 })
 
 app.get('/', (c) => {
-  return c.json({ message: 'Vicinae Extension Store API TEST' })
+  return c.json({ message: 'Vicinae Backend' })
 })
 
-if (storage instanceof LocalStorageAdapter) {
-  app.get('/storage/*', async (c) => {
-    try {
-      const path = c.req.path.replace('/storage/', '');
-      const file = await storage.get(path);
-
-      const contentType = getMimeType(path);
-      const filename = path.split('/').pop();
-
-      // For images and markdown, use inline display instead of attachment
-      const isInline = contentType.startsWith('image/') || contentType === 'text/markdown';
-
-      // Compute ETag from file buffer for cache validation
-      const crypto = await import('crypto');
-      const hash = crypto.createHash('md5').update(file).digest('hex');
-      const etag = `"${hash}"`;
-
-      // Check if client has cached version
-      const ifNoneMatch = c.req.header('if-none-match');
-      if (ifNoneMatch === etag) {
-        return new Response(null, { status: 304 });
-      }
+app.route('/', extensionsRouter)
 
-      return new Response(file, {
-        headers: {
-          'Content-Type': contentType,
-          'Content-Disposition': isInline
-            ? `inline; filename="${filename}"`
-            : `attachment; filename="${filename}"`,
-          // Cache for 1 year since files are content-addressed (path includes version)
-          'Cache-Control': 'public, max-age=31536000, immutable',
-          'ETag': etag,
-        },
-      });
-    } catch (error) {
-      return c.json({ error: 'File not found' }, 404);
-    }
-  });
+if (storage instanceof LocalStorageAdapter) {
+	app.route('/', localStorageRouter);
 }
 
-app.route('/', extensionsRouter)
-
 export default app

src/routes/extensions.ts

@@ -11,12 +11,7 @@ import { fetchGitHubUser, getDisplayName } from '../utils/github.js';
 import { getExtensionGitHubUrls, buildAssetUrl } from '../utils/repository.js';
 import { parseIcon } from '../utils/icons.js';
 import { getMimeType } from '../utils/mime.js';
-
-type AppContext = {
-  Variables: {
-    storage: StorageAdapter;
-  };
-};
+import type { AppContext } from '../types/app.js';
 
 const app = new Hono<AppContext>();
 

src/routes/storage.ts

@@ -0,0 +1,47 @@
+import { Hono } from "hono";
+import { getMimeType } from "../utils/mime";
+import type { AppContext } from '../types/app.js';
+
+const app = new Hono<AppContext>();
+
+app.get('/storage/*', async (c) => {
+try {
+  const storage = c.var.storage;
+  const path = c.req.path.replace('/storage/', '');
+  const file = await storage.get(path);
+
+  const contentType = getMimeType(path);
+  const filename = path.split('/').pop();
+
+  // For images and markdown, use inline display instead of attachment
+  const isInline = contentType.startsWith('image/') || contentType === 'text/markdown';
+
+  // Compute ETag from file buffer for cache validation
+  const crypto = await import('crypto');
+  const hash = crypto.createHash('md5').update(file).digest('hex');
+  const etag = `"${hash}"`;
+
+  // Check if client has cached version
+  const ifNoneMatch = c.req.header('if-none-match');
+  if (ifNoneMatch === etag) {
+	return new Response(null, { status: 304 });
+  }
+
+  return new Response(file, {
+	headers: {
+	  'Content-Type': contentType,
+	  'Content-Disposition': isInline
+		? `inline; filename="${filename}"`
+		: `attachment; filename="${filename}"`,
+	  // Cache for 1 year since files are content-addressed (path includes version)
+	  'Cache-Control': 'public, max-age=31536000, immutable',
+	  'ETag': etag,
+	},
+  });
+} catch (error) {
+  return c.json({ error: 'File not found' }, 404);
+}
+});
+
+
+export default app;

src/types/app.ts

@@ -0,0 +1,7 @@
+import type { StorageAdapter } from "../storage"
+
+export type AppContext = {
+  Variables: {
+    storage: StorageAdapter
+  }
+}