Merge branch 'master' into master

Author: vickygit-commits

DIRECTORY.md

@@ -304,7 +304,9 @@
             * [WildcardMatching](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/WildcardMatching.java)
             * [WineProblem](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/WineProblem.java)
           * geometry
+            * [ConvexHull](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/geometry/ConvexHull.java)
             * [GrahamScan](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/geometry/GrahamScan.java)
+            * [Point](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/geometry/Point.java)
           * greedyalgorithms
             * [ActivitySelection](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/greedyalgorithms/ActivitySelection.java)
             * [BinaryAddition](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/greedyalgorithms/BinaryAddition.java)
@@ -896,6 +898,7 @@
             * [WildcardMatchingTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/dynamicprogramming/WildcardMatchingTest.java)
             * [WineProblemTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/dynamicprogramming/WineProblemTest.java)
           * geometry
+            * [ConvexHullTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/geometry/ConvexHullTest.java)
             * [GrahamScanTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/geometry/GrahamScanTest.java)
           * greedyalgorithms
             * [ActivitySelectionTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/greedyalgorithms/ActivitySelectionTest.java)
@@ -1020,6 +1023,7 @@
             * [MirrorOfMatrixTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/misc/MirrorOfMatrixTest.java)
             * [PalindromeSinglyLinkedListTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/misc/PalindromeSinglyLinkedListTest.java)
             * [RangeInSortedArrayTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/misc/RangeInSortedArrayTest.java)
+            * [ThreeSumProblemTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/misc/ThreeSumProblemTest.java)
             * [TwoSumProblemTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/misc/TwoSumProblemTest.java)
             * [WordBoggleTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/misc/WordBoggleTest.java)
           * others

spotbugs-exclude.xml

@@ -87,9 +87,6 @@
         <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE" />
     </Match>
     <!-- fb-contrib -->
-    <Match>
-        <Bug pattern="OCP_OVERLY_CONCRETE_PARAMETER" />
-    </Match>
     <Match>
         <Bug pattern="LSC_LITERAL_STRING_COMPARISON" />
     </Match>

src/main/java/com/thealgorithms/backtracking/CrosswordSolver.java

@@ -1,6 +1,7 @@
 package com.thealgorithms.backtracking;
 
 import java.util.ArrayList;
+import java.util.Collection;
 import java.util.List;
 
 /**
@@ -95,7 +96,7 @@ public static void removeWord(char[][] puzzle, String word, int row, int col, bo
      * @param words  The list of words to be placed.
      * @return true if the crossword is solved, false otherwise.
      */
-    public static boolean solveCrossword(char[][] puzzle, List<String> words) {
+    public static boolean solveCrossword(char[][] puzzle, Collection<String> words) {
         // Create a mutable copy of the words list
         List<String> remainingWords = new ArrayList<>(words);
 

src/main/java/com/thealgorithms/datastructures/graphs/AStar.java

@@ -94,7 +94,7 @@ public int getEstimated() {
     }
 
     // Initializes the graph with edges defined in the input data
-    static void initializeGraph(Graph graph, ArrayList<Integer> data) {
+    static void initializeGraph(Graph graph, List<Integer> data) {
         for (int i = 0; i < data.size(); i += 4) {
             graph.addEdge(new Edge(data.get(i), data.get(i + 1), data.get(i + 2)));
         }

src/main/java/com/thealgorithms/datastructures/graphs/EdmondsBlossomAlgorithm.java

@@ -30,7 +30,7 @@ private EdmondsBlossomAlgorithm() {
      * @param vertexCount The number of vertices in the graph.
      * @return A list of matched pairs of vertices.
      */
-    public static List<int[]> maximumMatching(List<int[]> edges, int vertexCount) {
+    public static List<int[]> maximumMatching(Iterable<int[]> edges, int vertexCount) {
         List<List<Integer>> graph = new ArrayList<>(vertexCount);
 
         // Initialize each vertex's adjacency list.

src/main/java/com/thealgorithms/datastructures/lists/MergeSortedArrayList.java

@@ -1,6 +1,7 @@
 package com.thealgorithms.datastructures.lists;
 
 import java.util.ArrayList;
+import java.util.Collection;
 import java.util.List;
 
 /**
@@ -38,7 +39,7 @@ public static void main(String[] args) {
      * @param listB the second list to merge
      * @param listC the result list after merging
      */
-    public static void merge(List<Integer> listA, List<Integer> listB, List<Integer> listC) {
+    public static void merge(List<Integer> listA, List<Integer> listB, Collection<Integer> listC) {
         int pa = 0;
         /* the index of listA */
         int pb = 0;

src/main/java/com/thealgorithms/geometry/ConvexHull.java

@@ -0,0 +1,117 @@
+package com.thealgorithms.geometry;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.TreeSet;
+
+/**
+ * A class providing algorithms to compute the convex hull of a set of points
+ * using brute-force and recursive methods.
+ *
+ * Convex hull: The smallest convex polygon that contains all the given points.
+ *
+ * Algorithms provided:
+ * 1. Brute-Force Method
+ * 2. Recursive (Divide-and-Conquer) Method
+ *
+ * @author Hardvan
+ */
+public final class ConvexHull {
+    private ConvexHull() {
+    }
+
+    private static boolean checkPointOrientation(Point i, Point j, Point k) {
+        int detK = Point.orientation(i, j, k);
+        if (detK > 0) {
+            return true; // pointsLeftOfIJ
+        } else if (detK < 0) {
+            return false; // pointsRightOfIJ
+        } else {
+            return k.compareTo(i) >= 0 && k.compareTo(j) <= 0;
+        }
+    }
+
+    public static List<Point> convexHullBruteForce(List<Point> points) {
+        Set<Point> convexSet = new TreeSet<>(Comparator.naturalOrder());
+
+        for (int i = 0; i < points.size() - 1; i++) {
+            for (int j = i + 1; j < points.size(); j++) {
+                boolean allPointsOnOneSide = true;
+                boolean leftSide = checkPointOrientation(points.get(i), points.get(j), points.get((i + 1) % points.size()));
+
+                for (int k = 0; k < points.size(); k++) {
+                    if (k != i && k != j && checkPointOrientation(points.get(i), points.get(j), points.get(k)) != leftSide) {
+                        allPointsOnOneSide = false;
+                        break;
+                    }
+                }
+
+                if (allPointsOnOneSide) {
+                    convexSet.add(points.get(i));
+                    convexSet.add(points.get(j));
+                }
+            }
+        }
+
+        return new ArrayList<>(convexSet);
+    }
+
+    public static List<Point> convexHullRecursive(List<Point> points) {
+        Collections.sort(points);
+        Set<Point> convexSet = new HashSet<>();
+        Point leftMostPoint = points.get(0);
+        Point rightMostPoint = points.get(points.size() - 1);
+
+        convexSet.add(leftMostPoint);
+        convexSet.add(rightMostPoint);
+
+        List<Point> upperHull = new ArrayList<>();
+        List<Point> lowerHull = new ArrayList<>();
+
+        for (int i = 1; i < points.size() - 1; i++) {
+            int det = Point.orientation(leftMostPoint, rightMostPoint, points.get(i));
+            if (det > 0) {
+                upperHull.add(points.get(i));
+            } else if (det < 0) {
+                lowerHull.add(points.get(i));
+            }
+        }
+
+        constructHull(upperHull, leftMostPoint, rightMostPoint, convexSet);
+        constructHull(lowerHull, rightMostPoint, leftMostPoint, convexSet);
+
+        List<Point> result = new ArrayList<>(convexSet);
+        Collections.sort(result);
+        return result;
+    }
+
+    private static void constructHull(Collection<Point> points, Point left, Point right, Set<Point> convexSet) {
+        if (!points.isEmpty()) {
+            Point extremePoint = null;
+            int extremePointDistance = Integer.MIN_VALUE;
+            List<Point> candidatePoints = new ArrayList<>();
+
+            for (Point p : points) {
+                int det = Point.orientation(left, right, p);
+                if (det > 0) {
+                    candidatePoints.add(p);
+                    if (det > extremePointDistance) {
+                        extremePointDistance = det;
+                        extremePoint = p;
+                    }
+                }
+            }
+
+            if (extremePoint != null) {
+                constructHull(candidatePoints, left, extremePoint, convexSet);
+                convexSet.add(extremePoint);
+                constructHull(candidatePoints, extremePoint, right, convexSet);
+            }
+        }
+    }
+}

src/main/java/com/thealgorithms/geometry/GrahamScan.java

@@ -2,7 +2,6 @@
 
 import java.util.ArrayList;
 import java.util.Arrays;
-import java.util.Comparator;
 import java.util.Stack;
 
 /**
@@ -66,93 +65,4 @@ public GrahamScan(Point[] points) {
     public Iterable<Point> hull() {
         return new ArrayList<>(hull);
     }
-
-    public record Point(int x, int y) implements Comparable<Point> {
-
-        /**
-         * Default constructor
-         * @param x x-coordinate
-         * @param y y-coordinate
-         */
-        public Point {
-        }
-
-        /**
-         * @return the x-coordinate
-         */
-        @Override
-        public int x() {
-            return x;
-        }
-
-        /**
-         * @return the y-coordinate
-         */
-        @Override
-        public int y() {
-            return y;
-        }
-
-        /**
-         * Determines the orientation of the triplet (a, b, c).
-         *
-         * @param a The first point
-         * @param b The second point
-         * @param c The third point
-         * @return -1 if (a, b, c) is clockwise, 0 if collinear, +1 if counterclockwise
-         */
-        public static int orientation(Point a, Point b, Point c) {
-            int val = (b.x - a.x) * (c.y - a.y) - (b.y - a.y) * (c.x - a.x);
-            return Integer.compare(val, 0);
-        }
-
-        /**
-         * Compares this point with another point.
-         *
-         * @param p2 The point to compare to
-         * @return A positive integer if this point is greater, a negative integer if less, or 0 if equal
-         */
-        @Override
-        public int compareTo(Point p2) {
-            int cmpY = Integer.compare(this.y, p2.y);
-            return cmpY != 0 ? cmpY : Integer.compare(this.x, p2.x);
-        }
-
-        /**
-         * Returns a comparator to sort points by their polar order relative to this point.
-         *
-         * @return A polar order comparator
-         */
-        public Comparator<Point> polarOrder() {
-            return new PolarOrder();
-        }
-
-        private final class PolarOrder implements Comparator<Point> {
-            @Override
-            public int compare(Point p1, Point p2) {
-                int dx1 = p1.x - x;
-                int dy1 = p1.y - y;
-                int dx2 = p2.x - x;
-                int dy2 = p2.y - y;
-
-                if (dy1 >= 0 && dy2 < 0) {
-                    return -1; // p1 above p2
-                } else if (dy2 >= 0 && dy1 < 0) {
-                    return 1; // p1 below p2
-                } else if (dy1 == 0 && dy2 == 0) { // Collinear and horizontal
-                    return Integer.compare(dx2, dx1);
-                } else {
-                    return -orientation(Point.this, p1, p2); // Compare orientation
-                }
-            }
-        }
-
-        /**
-         * @return A string representation of this point in the format (x, y)
-         */
-        @Override
-        public String toString() {
-            return String.format("(%d, %d)", x, y);
-        }
-    }
 }

src/main/java/com/thealgorithms/geometry/Point.java

@@ -0,0 +1,45 @@
+package com.thealgorithms.geometry;
+
+import java.util.Comparator;
+
+public record Point(int x, int y) implements Comparable<Point> {
+
+    @Override
+    public int compareTo(Point other) {
+        int cmpY = Integer.compare(this.y, other.y);
+        return cmpY != 0 ? cmpY : Integer.compare(this.x, other.x);
+    }
+
+    @Override
+    public String toString() {
+        return String.format("(%d, %d)", x, y);
+    }
+
+    public Comparator<Point> polarOrder() {
+        return new PolarOrder();
+    }
+
+    public static int orientation(Point a, Point b, Point c) {
+        return Integer.compare((b.x - a.x) * (c.y - a.y) - (b.y - a.y) * (c.x - a.x), 0);
+    }
+
+    private final class PolarOrder implements Comparator<Point> {
+        @Override
+        public int compare(Point p1, Point p2) {
+            int dx1 = p1.x - x;
+            int dy1 = p1.y - y;
+            int dx2 = p2.x - x;
+            int dy2 = p2.y - y;
+
+            if (dy1 >= 0 && dy2 < 0) {
+                return -1; // p1 above p2
+            } else if (dy2 >= 0 && dy1 < 0) {
+                return 1; // p1 below p2
+            } else if (dy1 == 0 && dy2 == 0) { // Collinear and horizontal
+                return Integer.compare(dx2, dx1);
+            } else {
+                return -orientation(Point.this, p1, p2); // Compare orientation
+            }
+        }
+    }
+}

src/main/java/com/thealgorithms/maths/CircularConvolutionFFT.java

@@ -1,6 +1,7 @@
 package com.thealgorithms.maths;
 
 import java.util.ArrayList;
+import java.util.Collection;
 
 /**
  * Class for circular convolution of two discrete signals using the convolution
@@ -19,7 +20,7 @@ private CircularConvolutionFFT() {
      * @param x The signal to be padded.
      * @param newSize The new size of the signal.
      */
-    private static void padding(ArrayList<FFT.Complex> x, int newSize) {
+    private static void padding(Collection<FFT.Complex> x, int newSize) {
         if (x.size() < newSize) {
             int diff = newSize - x.size();
             for (int i = 0; i < diff; i++) {