Skip to content

Conversation

@filiphr
Copy link
Contributor

@filiphr filiphr commented Jan 6, 2026

  • Update actions/checkout to v6
  • Update actions/setup-java to v5 and use Eclipse Temurin distribution in builds
  • Update actions/cache to v5

@CarstenWickner as promised in #556, this is a PR that updates the versions of the different GitHub actions

* Update actions/checkout to v6
* Update actions/setup-java to v5 and use Eclipse Temurin distribution in builds
* Update actions/cache to v5
@filiphr
Copy link
Contributor Author

filiphr commented Jan 6, 2026

@CarstenWickner one thing I noticed is that you have different actions for build, checkstyle audit and tests. Is there a reason why not to do all of that in one single job? e.g. run mvn install which would do all the different 4 checks into one?

@CarstenWickner
Copy link
Member

CarstenWickner commented Jan 12, 2026

I just liked the separate checks being listed on the PR, so you see on a quick glance which part failed, if there is any issue.
Also: some things (JavaDoc, SlateDocs & Checkstyle) only need to be done once, but I prefer doing the build and test on multiple Java versions (just didn't extend it to 21 again, yet).

@CarstenWickner CarstenWickner merged commit 05732e0 into victools:main Jan 12, 2026
9 checks passed
@filiphr filiphr deleted the github-actions-update branch January 13, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants