Utils: Refactor and Test Updates (flexflow#1464)

* removed GraphInternal

* minor changes

* Added views.cc testing

* Fixed containers testing

* views.cc fix

* test reorganizing

* fmt

* test rearranging

* rearranging

* graph fixes

* undirected graph test fix

* Updated docs

* Test updates + bug fixes

* minor fix

* PR fixes

* moved graph-testing to other PR

* minor fixes

* Remove unnecessary includes

* Post-merge fixes

* Small bugfix and remove some unnecessary includes

---------

Co-authored-by: Pietro Max Marsella <[email protected]>
Co-authored-by: Colin Unger <[email protected]>
Co-authored-by: Colin Unger <[email protected]>

Author: 3 people

lib/compiler/src/compiler/machine_mapping/machine_mapping.cc

@@ -1,5 +1,4 @@
 #include "compiler/machine_mapping/machine_mapping.h"
-#include "utils/containers.h"
 #include "utils/containers/are_disjoint.h"
 #include "utils/containers/keys.h"
 #include "utils/containers/merge_maps.h"

lib/kernels/include/kernels/accessor.h

@@ -7,7 +7,6 @@
 #include "op-attrs/datatype.h"
 #include "utils/exception.h"
 #include "utils/required.h"
-#include "utils/variant.h"
 
 namespace FlexFlow {
 

lib/kernels/include/kernels/initializer_kernels.h

@@ -4,7 +4,6 @@
 #include "accessor.h"
 #include "kernels/cpu.h"
 #include "op-attrs/datatype_value.dtg.h"
-#include "utils/variant.h"
 
 namespace FlexFlow {
 

lib/kernels/test/src/test_dropout.cc

@@ -1,7 +1,6 @@
 #include "doctest/doctest.h"
 #include "kernels/dropout_kernels.h"
 #include "test_utils.h"
-#include "utils/containers.h"
 
 using namespace ::FlexFlow;
 TEST_SUITE(FF_TEST_SUITE) {

lib/pcg/include/pcg/optimizer_attrs.h

@@ -3,7 +3,7 @@
 
 #include "pcg/optimizers/adam_optimizer_attrs.h"
 #include "pcg/optimizers/sgd_optimizer_attrs.h"
-#include "utils/variant.h"
+#include <variant>
 
 namespace FlexFlow {
 

lib/pcg/src/pcg/operator_task_space.cc

@@ -5,6 +5,7 @@
 #include "utils/containers/range.h"
 #include "utils/containers/transform.h"
 #include "utils/containers/unordered_set_of.h"
+#include "utils/fmt/unordered_set.h"
 
 namespace FlexFlow {
 
@@ -25,7 +26,7 @@ std::unordered_set<TaskSpaceCoordinate>
 
 TaskSpaceCoordinate
     get_task_space_maximum_coordinate(OperatorTaskSpace const &task) {
-  return maximum(get_task_space_coordinates(task)).value();
+  return maximum(get_task_space_coordinates(task));
 }
 
 size_t num_dims(OperatorTaskSpace const &task) {

lib/runtime/src/model.cc

@@ -27,7 +27,6 @@
 #include "parallel_tensor_mapping.h"
 #include "task_spec/task_argument_accessor.h"
 #include "test_utils.h"
-#include "utils/containers.h"
 #include "utils/random_utils.h"
 #include <dirent.h>
 #include <queue>

lib/runtime/src/task_invocation_compilation.cc

@@ -1,5 +1,4 @@
 #include "task_invocation_compilation.h"
-#include "utils/containers.h"
 
 namespace FlexFlow {
 

lib/runtime/src/task_spec/task_invocation_compilation.cc

@@ -1,5 +1,4 @@
 #include "task_invocation_compilation.h"
-#include "utils/containers.h"
 
 namespace FlexFlow {
 

lib/runtime/src/task_spec/tensor_args_format.cc

@@ -1,5 +1,5 @@
 #include "tensor_args_format.h"
-#include "utils/containers.h"
+#include "utils/containers/flatmap.h"
 
 namespace FlexFlow {