Skip to content

Commit e215504

Browse files
committed
Simpler renaming
1 parent cf11379 commit e215504

File tree

4 files changed

+11
-12
lines changed

4 files changed

+11
-12
lines changed

api-extractor/report/hls.js.api.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,8 @@ export class BaseStreamController extends TaskLoop implements NetworkComponentAP
317317
// (undocumented)
318318
protected buffering: boolean;
319319
// (undocumented)
320+
protected cachePreloadHint(details: LevelDetails): void;
321+
// (undocumented)
320322
protected checkLiveUpdate(details: LevelDetails): void;
321323
// (undocumented)
322324
protected clearTrackerIfNeeded(frag: Fragment): void;
@@ -407,8 +409,6 @@ export class BaseStreamController extends TaskLoop implements NetworkComponentAP
407409
// (undocumented)
408410
protected levels: Array<Level> | null;
409411
// (undocumented)
410-
protected loadAndCachePreloadHint(details: LevelDetails): void;
411-
// (undocumented)
412412
protected loadedEndOfParts(partList: Part[], targetBufferTime: number): boolean;
413413
// (undocumented)
414414
protected loadedmetadata: boolean;

src/controller/base-stream-controller.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -353,12 +353,12 @@ export default class BaseStreamController
353353
this.initPTS = [];
354354
}
355355

356-
protected loadAndCachePreloadHint(details: LevelDetails): void {
356+
protected cachePreloadHint(details: LevelDetails): void {
357357
const data = details.preloadData;
358358
if (!data) {
359359
return;
360360
}
361-
this.fragmentPreloader.preload(data.frag, data.part);
361+
this.fragmentPreloader.cache(data.frag, data.part);
362362
}
363363

364364
protected onHandlerDestroying() {
@@ -819,10 +819,9 @@ export default class BaseStreamController
819819
loadedEndOfParts &&
820820
this.hls.lowLatencyMode &&
821821
details?.live &&
822-
details.canBlockReload &&
823-
!this.fragmentPreloader.loading
822+
details.canBlockReload
824823
) {
825-
this.loadAndCachePreloadHint(details);
824+
this.cachePreloadHint(details);
826825
}
827826
// Fragment hint has no parts
828827
return Promise.resolve(null);

src/controller/stream-controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -659,7 +659,7 @@ export default class StreamController
659659
) {
660660
this.fragmentPreloader.abort();
661661
} else {
662-
// reset the preloader state to IDLE if we have finished loading, never loaded, or have old data
662+
// reset the preloader state if we have finished loading, never loaded, or have old data
663663
this.fragmentPreloader.revalidate(data);
664664
}
665665
if (newDetails.deltaUpdateFailed) {

src/loader/fragment-preloader.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export default class FragmentPreloader extends FragmentLoader {
3838
this.log = logger.log.bind(logger, `${logPrefix}>preloader:`);
3939
}
4040

41-
private getPreloadStateStr() {
41+
private getStateString() {
4242
switch (this.storage.state) {
4343
case FragRequestState.IDLE:
4444
return 'IDLE ';
@@ -61,15 +61,15 @@ export default class FragmentPreloader extends FragmentLoader {
6161
return request !== undefined && state !== FragRequestState.IDLE;
6262
}
6363

64-
public preload(frag: Fragment, part: Part | undefined): void {
64+
public cache(frag: Fragment, part: Part | undefined): void {
6565
if (this.has(frag, part)) {
6666
return;
6767
} else {
6868
this.abort();
6969
}
7070

7171
this.log(
72-
`[${this.getPreloadStateStr()}] create request for [${frag.type}] ${
72+
`[${this.getStateString()}] create request for [${frag.type}] ${
7373
frag.sn
7474
}:${part?.index}`,
7575
);
@@ -104,7 +104,7 @@ export default class FragmentPreloader extends FragmentLoader {
104104
const cacheHit = this.has(frag, part);
105105

106106
this.log(
107-
`[${this.getPreloadStateStr()}] check cache for [${frag.type}] ${
107+
`[${this.getStateString()}] check cache for [${frag.type}] ${
108108
frag.sn
109109
}:${part?.index ?? ''} / have: ${request.frag.sn}:${request.part?.index ?? ''} hit=${cacheHit}`,
110110
);

0 commit comments

Comments
 (0)