Fix issue where some devices not works with playready #7631
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
previously approved these changes
Nov 7, 2025
robwalch
reviewed
Nov 7, 2025
github-project-automation
bot
moved this to Top priorities
in HLS.js Release Planning and Backlog
robwalch
approved these changes
Nov 13, 2025
github-project-automation
bot
moved this from Top priorities
to Done
in HLS.js Release Planning and Backlog
robwalch
pushed a commit
that referenced
this pull request
Nov 14, 2025
(cherry picked from commit 6238bc8)
robwalch
added a commit
that referenced
this pull request
Nov 19, 2025
* patch/v1.6.x: Increase minimum Windows test version for saucelabs Fix FairPlay key ID patching Fixes "keyId is null" error mentioned in #7542 (comment) #7654 Fix fallback to primary on live start Fixes #7641 Do not reset interstitial when seeking between assets Fixes #7640 Fixed issue with progressive loading of subtitles by disabling progressive loading for webVTT (#7649) Fix audio TS segment duration calculation ##7646 (comment) Resolve end-of-stream with empty or gap segments at end of playlist Fixes #7572 (and maybe #7564) Fix issue where some devices not works with playready (#7631) Fix switching back to main audio after end-of-stream buffered Fixes #7643
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Cache both the endianness-converted key ID and the original key ID to prevent key ID mismatch issues in PlayReady.
Why is this Pull Request needed?
On certain devices, the key ID received from the `keystatuseschange event is already endianness-converted. Reapplying endianness conversion in such cases causes a mismatch with the cached key ID, which can trigger EME errors and result in playback failure.
Are there any points in the code the reviewer needs to double check?
Please review the key ID caching logic to ensure it correctly handles both converted and original key IDs across all device cases.
Resolves issues:
Fix #7580
Checklist