fix: prevent errors in getKeyIdSet if playlist.contentProtection object is incomplete (#1582)

Author: Essk

src/playlist-loader.js

@@ -1317,17 +1317,21 @@ export default class PlaylistLoader extends EventTarget {
    * @return a Set of 32 digit hex strings that represent the unique keyIds for that playlist.
    */
   getKeyIdSet(playlist) {
-    if (playlist.contentProtection) {
-      const keyIds = new Set();
+    const keyIds = new Set();
 
-      for (const keysystem in playlist.contentProtection) {
+    if (!playlist || !playlist.contentProtection) {
+      return keyIds;
+    }
+
+    for (const keysystem in playlist.contentProtection) {
+      if (playlist.contentProtection[keysystem] &&
+          playlist.contentProtection[keysystem].attributes &&
+          playlist.contentProtection[keysystem].attributes.keyId) {
         const keyId = playlist.contentProtection[keysystem].attributes.keyId;
 
-        if (keyId) {
-          keyIds.add(keyId.toLowerCase());
-        }
+        keyIds.add(keyId.toLowerCase());
       }
-      return keyIds;
     }
+    return keyIds;
   }
 }

test/playlist-loader.test.js

@@ -49,6 +49,39 @@ QUnit.module('Playlist Loader', function(hooks) {
     assert.ok(keyIdSet.has(keyId.toLowerCase()), 'keyId is expected hex string');
   });
 
+  QUnit.test('does not error if keyId or keysystem.attributes is missing', function(assert) {
+    assert.expect(6);
+    const loader = new PlaylistLoader('variant.m3u8', this.fakeVhs);
+    const playlists = [
+      {
+        contentProtection: {
+          'fake.keysystem': {}
+        }
+      },
+      {
+        contentProtection: {
+          'fake.keysystem': {
+            attributes: {}
+          }
+        }
+      }
+    ];
+
+    let errorHappened = false;
+
+    for (const playlist of playlists) {
+      let keyIdSet;
+
+      try {
+        keyIdSet = loader.getKeyIdSet(playlist);
+      } catch (e) {
+        errorHappened = true;
+      }
+      assert.notOk(errorHappened, 'no error was thrown');
+      assert.notOk(keyIdSet.size, 'keyIdSet is empty');
+    }
+  });
+
   QUnit.test('updateSegments copies over properties', function(assert) {
     assert.deepEqual(
       [