fix env var replacement with lists, simplify debug of installer script

Author: Georg Martin Weber

hull-vidispine-addon/Chart.yaml

@@ -3,4 +3,4 @@ apiVersion: v1
 appVersion: 1.30.0
 description: hull-vidispine-addon
 name: hull-vidispine-addon
-version: 1.30.1
+version: 1.30.2

hull-vidispine-addon/README.md

@@ -115,6 +115,7 @@ Describes configuration options. <br>Has exclusively the following sub-fields: <
 | `debug.ignoreEntityRestCallErrors` | If `false`, the `hull-install` and `hull-configure` scripts will stop after an error was encountered and the allowed number of retries was exceeded. To instead ignore errors and provide a list of failed `entities` after execution set this value to `true`, This can be useful for debugging potential issues with Helm Charts. | `false` | `true`
 | `debug.retriesForEntityRestCall` | Sets number of retries for each individual GET, PUT, POST and DELETE call before considering the operation failed. | `3` | `1`
 | `debug.retriesForEntityRestCall` | Sets number of retries for each individual GET, PUT, POST and DELETE call before considering the operation failed. | `5` | `2`
+| `debug.debugInstallerScript` | If enabled, the Installer.ps1 script is not being run embedded in the container but is mounted and run from the hull-install ConfigMap. Normally to not clutter the configuration the script is embedded into the container and cannot be debugged easily without creating new container images. To easily debug `Installer.ps1` script, copy the current script from the `/images/hull-integration/Installer.ps1` file to the ConfigMap `Installer.ps1` inline placeholder. Now when making changes to the ConfigMap entry this will affect the Job that is executed. | `false` | `true`
 | `legacy` | Setttings for legacy compatibility.
 | `legacy.defaultServiceAccountIsHook` |  In older versions of the `hull-vidispine-addon`, the `default` ServiceAccount that is being created by HULL was annotated as a Helm hook by the `hull-vidispine-addon`and used for all pods in the Helm chart. This behavior was problematic because the Hook lifecycle was only appropriate for the `hull-vidispine-addon` jobs but not the remaining pods. Furthermore it opposed granular RBAC settings for the `hull-install` Jobs vs. continuously running regular pods. So by now there are different Helm hook ServiceAccounts created for the `hull-install` and `hull-configure` job and the `default` ServiceAccount is not annotated as a Helm hook anymore.<br><br> This setting should **NEVER** be set to `true` for new Helm charts, only for a transition phase it may be useful to set it to `true` to avoid immediate migration issues. | `false` | `true`
 ### EndpointSpec

hull-vidispine-addon/hull-vidispine-addon.yaml

@@ -19,6 +19,7 @@ hull:
               ignoreEntityRestCallErrors: false
               retriesForEntityRestCall: 3
               retriesForAuthServiceCall: 10
+              debugInstallerScript: false
             legacy:
               defaultServiceAccountIsHook: false
             runtime:
@@ -683,4 +684,11 @@ hull:
                   {{- end }}
                   {{- $_ := include "hull.util.transformation" (dict "PARENT_CONTEXT" $ "SOURCE" $configScope "CALLER" nil "CALLER_KEY" nil "SOURCE_PATH" list) -}}
                   {{- toYaml $configScope -}}
-                {{ end }}
+                {{ end }}
+          Installer.ps1:
+            enabled: _HT*hull.config.general.data.installation.config.debug.debugInstallerScript
+            inline: |-
+              *** ENABLE hull.config.general.data.installation.config.debug.debugInstallerScript
+              *** AND COPY SCRIPT CODE FROM 
+              *** /images/hull-integration/Installer.ps1 
+              *** HERE TO START DEBUGGING 

hull-vidispine-addon/templates/_transformations.tpl

@@ -169,6 +169,14 @@ Icon: |-
     "mountPath": "/script/installation.yaml",
     "subPath": "installation.yaml"
   },
+{{ if $parent.Values.hull.config.general.data.installation.config.debug.debugInstallerScript }}
+  "installer": 
+  {
+    "name": "installation",
+    "mountPath": "/script/Installer.ps1",
+    "subPath": "Installer.ps1"
+  },
+{{ end }}
   "custom-installation-files":
   {
     "name": "custom-installation-files",

images/hull-integration/Installer.ps1

@@ -529,6 +529,11 @@ Class Installer
       $this.WriteLog("+++++ Converting Content from OrderedDictionary to JSON for environment variable insertion")
       $source = $source | ConvertTo-Json
     }
+    if ($source.GetType() -Eq [System.Collections.Generic.List[System.Object]])
+    {
+      $this.WriteLog("+++++ Converting Content from Generic.List[System.Object] to JSON for environment variable insertion")
+      $source = $source | ConvertTo-Json
+    }
 
     Select-String '\$\{env:(.*)\}' -Input $source -AllMatches | ForEach-Object {
       $_.matches | ForEach-Object {