Feat: insertDate and read data type

viest · viest · commit 191f247c820f · 2019-09-11T22:54:29.000+08:00
diff --git a/kernel/excel.c b/kernel/excel.c
@@ -462,7 +462,8 @@ PHP_METHOD(vtiful_xls, insertDate)
     SHEET_LINE_SET(obj, row);
 
     if (Z_TYPE_P(data) != IS_LONG) {
-        // throw
+        zend_throw_exception(vtiful_exception_ce, "timestamp is long", 160);
+        return;
     }
 
     // Default datetime format
@@ -471,7 +472,7 @@ PHP_METHOD(vtiful_xls, insertDate)
     }
 
     zval _zv_double_time;
-    ZVAL_DOUBLE(&_zv_double_time, ((double)data->value.lval / 86400 + 25569))
+    ZVAL_DOUBLE(&_zv_double_time, ((double)data->value.lval / 86400 + 25569));
 
     if (format_handle) {
         type_writer(&_zv_double_time, row, column, &obj->write_ptr, format, zval_get_format(format_handle));

Original file line number	Diff line number	Diff line change
`@@ -462,7 +462,8 @@ PHP_METHOD(vtiful_xls, insertDate)`
`462`	`462`	`SHEET_LINE_SET(obj, row);`
`463`	`463`
`464`	`464`	`if (Z_TYPE_P(data) != IS_LONG) {`
`465`		`- // throw`
	`465`	`+ zend_throw_exception(vtiful_exception_ce, "timestamp is long", 160);`
	`466`	`+ return;`
`466`	`467`	`}`
`467`	`468`
`468`	`469`	`// Default datetime format`
`@@ -471,7 +472,7 @@ PHP_METHOD(vtiful_xls, insertDate)`
`471`	`472`	`}`
`472`	`473`
`473`	`474`	`zval _zv_double_time;`
`474`		`- ZVAL_DOUBLE(&_zv_double_time, ((double)data->value.lval / 86400 + 25569))`
	`475`	`+ ZVAL_DOUBLE(&_zv_double_time, ((double)data->value.lval / 86400 + 25569));`
`475`	`476`
`476`	`477`	`if (format_handle) {`
`477`	`478`	`type_writer(&_zv_double_time, row, column, &obj->write_ptr, format, zval_get_format(format_handle));`