Fix: leaked

viest · viest · commit 58b4738148d3 · 2020-03-19T20:20:53.000+08:00
diff --git a/kernel/excel.c b/kernel/excel.c
@@ -566,7 +566,11 @@ PHP_METHOD(vtiful_xls, insertDate)
         type_writer(&_zv_double_time, row, column, &obj->write_ptr, format, obj->format_ptr.format);
     }
 
-    zend_string_release(format);
+    // Release default format
+    if (ZEND_NUM_ARGS() == 3) {
+        zend_string_release(format);
+    }
+
     zval_ptr_dtor(&_zv_double_time);
 }
 /* }}} */

Original file line number	Diff line number	Diff line change
`@@ -566,7 +566,11 @@ PHP_METHOD(vtiful_xls, insertDate)`
`566`	`566`	`type_writer(&_zv_double_time, row, column, &obj->write_ptr, format, obj->format_ptr.format);`
`567`	`567`	`}`
`568`	`568`
`569`		`- zend_string_release(format);`
	`569`	`+ // Release default format`
	`570`	`+ if (ZEND_NUM_ARGS() == 3) {`
	`571`	`+ zend_string_release(format);`
	`572`	`+ }`
	`573`	`+`
`570`	`574`	`zval_ptr_dtor(&_zv_double_time);`
`571`	`575`	`}`
`572`	`576`	`/* }}} */`