Skip to content

Commit fdc8709

Browse files
committed
Merge branch 'master' of github.com:viest/php-ext-excel-export
2 parents 3004646 + 196a54b commit fdc8709

File tree

5 files changed

+9
-5
lines changed

5 files changed

+9
-5
lines changed

README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
![php-excel](resource/logo.png)
1+
<div align=center>
2+
<img height="214" src="resource/logo_now.png"/>
3+
</div>
24

35
<div align=center>
46
<a href="https://travis-ci.org/viest/php-ext-xlswriter"><img src="https://travis-ci.org/viest/php-ext-xlswriter.svg?branch=master"/></a>

README_zh.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
![php-excel](resource/logo.png)
1+
<div align=center>
2+
<img height="214" src="resource/logo_now.png"/>
3+
</div>
24

35
<div align=center>
46
<a href="https://travis-ci.org/viest/php-ext-xlswriter"><img src="https://travis-ci.org/viest/php-ext-xlswriter.svg?branch=master"/></a>

kernel/excel.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,6 @@ PHP_METHOD(vtiful_xls, header)
392392

393393
ZEND_HASH_FOREACH_NUM_KEY_VAL(Z_ARRVAL_P(header), header_l_key, header_value)
394394
type_writer(header_value, 0, header_l_key, &obj->write_ptr, NULL, obj->format_ptr.format);
395-
zval_ptr_dtor(header_value);
396395
ZEND_HASH_FOREACH_END();
397396

398397
SHEET_LINE_ADD(obj)
@@ -419,7 +418,6 @@ PHP_METHOD(vtiful_xls, data)
419418
if(Z_TYPE_P(data_r_value) == IS_ARRAY) {
420419
ZEND_HASH_FOREACH_BUCKET(Z_ARRVAL_P(data_r_value), Bucket *bucket)
421420
type_writer(&bucket->val, SHEET_CURRENT_LINE(obj), bucket->h, &obj->write_ptr, NULL, obj->format_ptr.format);
422-
zval_ptr_dtor(&bucket->val);
423421
ZEND_HASH_FOREACH_END();
424422

425423
SHEET_LINE_ADD(obj)

kernel/write.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,9 @@ void type_writer(zval *value, zend_long row, zend_long columns, xls_resource_wri
2525
zend_uchar value_type = Z_TYPE_P(value);
2626

2727
if (value_type == IS_STRING) {
28-
worksheet_write_string(res->worksheet, lxw_row, lxw_col, ZSTR_VAL(zval_get_string(value)), format_handle);
28+
zend_string *_zs_value = zval_get_string(value);
29+
worksheet_write_string(res->worksheet, lxw_row, lxw_col, ZSTR_VAL(_zs_value), format_handle);
30+
zend_string_release(_zs_value);
2931
return;
3032
}
3133

resource/logo_now.png

7.42 KB
Loading

0 commit comments

Comments
 (0)