Adding disable_http_logs to add_parameter (#35)

* Adding disable_http_logs to add_parameter

* Added changes

* Fixing linters

Author: OskarLiew

CHANGES.md

@@ -9,6 +9,8 @@ All notable changes to this project will be documented in this file. This projec
 - Added the option to deploy from a local docker image with the CLI.
 - Added the option to keep the docker image when killing services
 - Added links to service paths to the dashboard
+- Improved redirecting of urls after logging in
+- Added `disable_http_logs` argument to `service.add_parameter`
 
 ### Bugfixes
 

daeploy/_service/service.py

@@ -36,6 +36,15 @@
 logger = logging.getLogger(__name__)
 
 
+def _disable_http_logs(path: str):
+    logging.getLogger("uvicorn.access").addFilter(
+        # Add a space to the path to make sure that we
+        # only filter out this entrypoints HTTP logs.
+        lambda record: f"{path} "
+        not in record.getMessage()
+    )
+
+
 class _Service:
     def __init__(self):
         self.app = FastAPI(
@@ -180,12 +189,7 @@ async def wrapper(_request: Request, *args, **kwargs):
             )
 
             if disable_http_logs:
-                logging.getLogger("uvicorn.access").addFilter(
-                    # Add a space to the path to make sure that we
-                    # only filter out this entrypoints HTTP logs.
-                    lambda record: f"{path} "
-                    not in record.getMessage()
-                )
+                _disable_http_logs(path)
 
             # Wrap the original func in a pydantic validation wrapper and return that
             return validate_arguments(deco_func)
@@ -319,6 +323,7 @@ def add_parameter(
         value: Any,
         expose: bool = True,
         monitor: bool = False,
+        disable_http_logs: bool = False,
     ):
         """Adds a parameter to the parameter endpoints.
 
@@ -329,8 +334,12 @@ def add_parameter(
                 Defaults to True.
             monitor (bool): Stores updates to this parameter in the monitoring
                 database if True. Will try to coerce non-numeric types to
-                string Defaults to False.
+                string. Defaults to False.
+            disable_http_logs (bool): Disable logs when getting and
+                setting paramter with API. Defaults to False
         """
+        path = f"/~parameters/{parameter}"
+
         if isinstance(value, Number):
             value = float(value)
 
@@ -342,6 +351,9 @@ def update_parameter(value: value.__class__) -> Any:
                 self.store(**{parameter: value})
             return value
 
+        if disable_http_logs:
+            _disable_http_logs(path)
+
         # Set initial value
         self.parameters[parameter] = {
             "value": None,
@@ -353,7 +365,6 @@ def update_parameter(value: value.__class__) -> Any:
         def get_parameter():
             return self.parameters[parameter]["value"]
 
-        path = f"/~parameters/{parameter}"
         self.app.get(path, tags=["Parameters"])(get_parameter)
 
         # Register POST endpoint for the new parameter

tests/e2e_test/downstream/downstream.py

@@ -12,6 +12,7 @@
 logger = logging.getLogger(__name__)
 
 service.add_parameter("greeting_phrase", "Hello")
+service.add_parameter("silent_log", True, disable_http_logs=True)
 
 
 @service.entrypoint

tests/e2e_test/e2e_test.py

@@ -374,6 +374,18 @@ def test_call_service_multiple_cases(
     assert resp.status_code == 200
     assert resp.json() == "Get - Got - Gotten"
 
+    # Test disable_http_logs
+    resp = requests.get(
+        url="http://localhost/services/downstream/~parameters/silent_log",
+        headers=headers,
+    )
+    assert resp.json() == True
+    logs = requests.get(
+        url="http://localhost/services/~logs?name=downstream&version=0.1.0",
+        headers=headers,
+    )
+    assert "GET /services/downstream_0.1.0/~parameters/silent_log" not in logs
+
 
 def test_raised_notification_from_service_ends_up_at_manager(
     dummy_manager, cli_auth_login, services, headers