Skip to content

Conversation

shargon
Copy link
Contributor

@shargon shargon commented May 18, 2025

Close #1108

The condition is wrong, it must be not

@shargon shargon changed the title Fix Toast Stack hide [Fix] Toast Stack hide May 18, 2025
@shargon
Copy link
Contributor Author

shargon commented Jun 10, 2025

Any update with this?

@gvreddy04
Copy link
Contributor

@shargon Can you help me reproduce this issue using a GitHub repository and minimal code?

@shargon
Copy link
Contributor Author

shargon commented Jun 15, 2025

Send 101 notifications at same time, it should fail (or reduce StackLength to 1 and send 2)

@shargon
Copy link
Contributor Author

shargon commented Jun 20, 2025

@shargon Can you help me reproduce this issue using a GitHub repository and minimal code?

But it's easy to see the error, only call JS when the id is empty, should be the opposite

@shargon
Copy link
Contributor Author

shargon commented Jun 21, 2025

@gvreddy04 can we move on this?

Copy link
Contributor

@gvreddy04 gvreddy04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gvreddy04 gvreddy04 merged commit 7b8f131 into vikramlearning:main Jun 23, 2025
@shargon shargon deleted the patch-1 branch June 23, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error with Toast sent from a different thread

2 participants