style: do not suppress lossy-conversions

Author: vil02

pom.xml

@@ -78,7 +78,6 @@
                         <arg>-Xlint:-auxiliaryclass</arg>
                         <arg>-Xlint:-rawtypes</arg>
                         <arg>-Xlint:-unchecked</arg>
-                        <arg>-Xlint:-lossy-conversions</arg>
                         <arg>-Werror</arg>
                     </compilerArgs>
                 </configuration>

src/main/java/com/thealgorithms/ciphers/Caesar.java

@@ -9,6 +9,9 @@
  * @author khalil2535
  */
 public class Caesar {
+    private static char normalizeShift(final int shift) {
+        return (char) (shift % 26);
+    }
 
     /**
      * Encrypt text by shifting every Latin char by add number shift for ASCII
@@ -19,7 +22,7 @@ public class Caesar {
     public String encode(String message, int shift) {
         StringBuilder encoded = new StringBuilder();
 
-        shift %= 26;
+        final char shiftChar = normalizeShift(shift);
 
         final int length = message.length();
         for (int i = 0; i < length; i++) {
@@ -29,10 +32,10 @@ public String encode(String message, int shift) {
             char current = message.charAt(i); // Java law : char + int = char
 
             if (isCapitalLatinLetter(current)) {
-                current += shift;
+                current += shiftChar;
                 encoded.append((char) (current > 'Z' ? current - 26 : current)); // 26 = number of latin letters
             } else if (isSmallLatinLetter(current)) {
-                current += shift;
+                current += shiftChar;
                 encoded.append((char) (current > 'z' ? current - 26 : current)); // 26 = number of latin letters
             } else {
                 encoded.append(current);
@@ -50,16 +53,16 @@ public String encode(String message, int shift) {
     public String decode(String encryptedMessage, int shift) {
         StringBuilder decoded = new StringBuilder();
 
-        shift %= 26;
+        final char shiftChar = normalizeShift(shift);
 
         final int length = encryptedMessage.length();
         for (int i = 0; i < length; i++) {
             char current = encryptedMessage.charAt(i);
             if (isCapitalLatinLetter(current)) {
-                current -= shift;
+                current -= shiftChar;
                 decoded.append((char) (current < 'A' ? current + 26 : current)); // 26 = number of latin letters
             } else if (isSmallLatinLetter(current)) {
-                current -= shift;
+                current -= shiftChar;
                 decoded.append((char) (current < 'a' ? current + 26 : current)); // 26 = number of latin letters
             } else {
                 decoded.append(current);

src/main/java/com/thealgorithms/maths/AliquotSum.java

@@ -56,7 +56,7 @@ public static int getAliquotSum(int n) {
         // if n is a perfect square then its root was added twice in above loop, so subtracting root
         // from sum
         if (root == (int) root) {
-            sum -= root;
+            sum -= (int) root;
         }
         return sum;
     }

src/main/java/com/thealgorithms/maths/PerfectNumber.java

@@ -63,7 +63,7 @@ public static boolean isPerfectNumber2(int n) {
         // if n is a perfect square then its root was added twice in above loop, so subtracting root
         // from sum
         if (root == (int) root) {
-            sum -= root;
+            sum -= (int) root;
         }
 
         return sum == n;