Explicitly check assumptions to avoid hanging on already read request

Author: brandon-leapyear

lib/requestOptions.js

@@ -90,6 +90,11 @@ function bodyContent(req, res, options) {
   function maybeParseBody(req, limit) {
     if (req.body) {
       return Promise.resolve(req.body);
+    } else if (!req.readable) {
+      return Promise.reject(
+        'Tried to parse body after request body has already been read.' +
+        ' Try setting parseReqBody to false and manually specify the body you want to send in decorateProxyReqBody.'
+      );
     } else {
       // Returns a promise
 

test/getBody.js

@@ -181,4 +181,70 @@ describe('when proxy request is a GET', function () {
       .end(done);
   });
 
+  describe('when body-parser.json() is using strict=false', function () {
+    beforeEach(function () {
+      localServer = createLocalApplicationServer();
+      localServer.use(bodyParser.json({ strict: false }));
+    });
+
+    var testCases = [
+      { value: false },
+      { value: null },
+      { value: '' },
+    ];
+
+    testCases.forEach(function (test) {
+      var valueString = JSON.stringify(test.value);
+
+      it('errors when body is ' + valueString, function (done) {
+        localServer.use('/proxy', proxy('http://127.0.0.1:12345'));
+        localServer.use(function (err, req, res, next) { res.send(err); next(); });
+
+        request(localServer)
+          .get('/proxy')
+          .send(valueString)
+          .set('Content-Type', 'application/json')
+          .expect(function (res) {
+            assert(
+              res.text === (
+                'Tried to parse body after request body has already been read.' +
+                ' Try setting parseReqBody to false and manually specify the body' +
+                ' you want to send in decorateProxyReqBody.'
+              )
+            );
+          })
+          .end(done);
+      });
+
+      it(
+        'succeeds when parseReqBody=false and proxyReqBodyDecorator explicitly returns ' + valueString,
+        function (done) {
+          var scope = nock('http://127.0.0.1:12345')
+            .get('/', valueString)
+            .matchHeader('Content-Type', 'application/json')
+            .reply(200, valueString, {
+              'Content-Type': 'application/json',
+            });
+
+          localServer.use('/proxy', proxy('http://127.0.0.1:12345', {
+            parseReqBody: false,
+            proxyReqBodyDecorator: function () {
+              return valueString;
+            },
+          }));
+
+          request(localServer)
+            .get('/proxy')
+            .send(valueString)
+            .set('Content-Type', 'application/json')
+            .expect(function (res) {
+              assert(res.body === test.value);
+              scope.done();
+            })
+            .end(done);
+        }
+      );
+    });
+  });
+
 });

test/postBody.js

@@ -154,4 +154,70 @@ describe('when proxy request is a POST', function () {
       .end(done);
   });
 
+  describe('when body-parser.json() is using strict=false', function () {
+    beforeEach(function () {
+      localServer = createLocalApplicationServer();
+      localServer.use(bodyParser.json({ strict: false }));
+    });
+
+    var testCases = [
+      { value: false },
+      { value: null },
+      { value: '' },
+    ];
+
+    testCases.forEach(function (test) {
+      var valueString = JSON.stringify(test.value);
+
+      it('errors when body is ' + valueString, function (done) {
+        localServer.use('/proxy', proxy('http://127.0.0.1:12345'));
+        localServer.use(function (err, req, res, next) { res.send(err); next(); });
+
+        request(localServer)
+          .post('/proxy')
+          .send(valueString)
+          .set('Content-Type', 'application/json')
+          .expect(function (res) {
+            assert(
+              res.text === (
+                'Tried to parse body after request body has already been read.' +
+                ' Try setting parseReqBody to false and manually specify the body' +
+                ' you want to send in decorateProxyReqBody.'
+              )
+            );
+          })
+          .end(done);
+      });
+
+      it(
+        'succeeds when parseReqBody=false and proxyReqBodyDecorator explicitly returns ' + valueString,
+        function (done) {
+          var scope = nock('http://127.0.0.1:12345')
+            .post('/', valueString)
+            .matchHeader('Content-Type', 'application/json')
+            .reply(200, valueString, {
+              'Content-Type': 'application/json',
+            });
+
+          localServer.use('/proxy', proxy('http://127.0.0.1:12345', {
+            parseReqBody: false,
+            proxyReqBodyDecorator: function () {
+              return valueString;
+            },
+          }));
+
+          request(localServer)
+            .post('/proxy')
+            .send(valueString)
+            .set('Content-Type', 'application/json')
+            .expect(function (res) {
+              assert(res.body === test.value);
+              scope.done();
+            })
+            .end(done);
+        }
+      );
+    });
+  });
+
 });