use body-parser to show a case where the body is passed as {}

when the original is an empty string

Author: cesine

test/getBody.js

@@ -1,6 +1,7 @@
 'use strict';
 
 var assert = require('assert');
+var bodyParser = require('body-parser');
 var express = require('express');
 var nock = require('nock');
 var request = require('supertest');
@@ -20,6 +21,7 @@ describe('when proxy request is a GET', function () {
 
   beforeEach(function () {
     localServer = createLocalApplicationServer();
+    localServer.use(bodyParser.json());
   });
 
   afterEach(function () {
@@ -58,7 +60,7 @@ describe('when proxy request is a GET', function () {
 
     it('should deliver the get body when ' + test.name, function (done) {
       var nockedPostWithEncoding = nock('http://127.0.0.1:12345')
-        .get('/', { name: 'tobi' })
+        .get('/', test.encoding.includes('json') ? { name: 'tobi' } : '')
         .matchHeader('Content-Type', test.encoding)
         .reply(200, {
           name: 'tobi'
@@ -82,7 +84,7 @@ describe('when proxy request is a GET', function () {
 
   it('should deliver empty string get body', function (done) {
     var nockedPostWithoutBody = nock('http://127.0.0.1:12345')
-      .get('/', '')
+      .get('/')
       .matchHeader('Content-Type', 'application/json')
       .reply(200, {
         name: 'get with string body'
@@ -94,7 +96,7 @@ describe('when proxy request is a GET', function () {
 
     request(localServer)
       .get('/proxy')
-      .send()
+      .send('')
       .set('Content-Type', 'application/json')
       .expect(function (res) {
         assert(res.body.name === 'get with string body');
@@ -126,4 +128,31 @@ describe('when proxy request is a GET', function () {
       .end(done);
   });
 
+  it('should support parseReqBody', function (done) {
+    var nockedPostWithBody = nock('http://127.0.0.1:12345')
+      .get('/', '')
+      .matchHeader('Content-Type', 'application/json')
+      .reply(200, {
+        name: 'get with parseReqBody false'
+      });
+
+    localServer.use('/proxy', proxy('http://127.0.0.1:12345', {
+      parseReqBody: false,
+    }));
+    localServer.use(function (req, res) { res.sendStatus(200); });
+    localServer.use(function (err, req, res, next) { throw new Error(err, req, res, next); });
+
+    request(localServer)
+      .get('/proxy')
+      .send({
+        name: 'tobi'
+      })
+      .set('Content-Type', 'application/json')
+      .expect(function (res) {
+        assert(res.body.name === 'get with parseReqBody false');
+        nockedPostWithBody.done();
+      })
+      .end(done);
+  });
+
 });

test/postBody.js

@@ -1,6 +1,7 @@
 'use strict';
 
 var assert = require('assert');
+var bodyParser = require('body-parser');
 var express = require('express');
 var nock = require('nock');
 var request = require('supertest');
@@ -20,6 +21,7 @@ describe('when proxy request is a POST', function () {
 
   beforeEach(function () {
     localServer = createLocalApplicationServer();
+    localServer.use(bodyParser.json());
   });
 
   afterEach(function () {
@@ -32,9 +34,33 @@ describe('when proxy request is a POST', function () {
   ];
 
   testCases.forEach(function (test) {
+    it('should deliver the post query when ' + test.name, function (done) {
+      var nockedPostWithEncoding = nock('http://127.0.0.1:12345')
+        .post('/')
+        .query({ name: 'tobi' })
+        .matchHeader('Content-Type', test.encoding)
+        .reply(200, {
+          name: 'tobi'
+        });
+
+      localServer.use('/proxy', proxy('http://127.0.0.1:12345'));
+      localServer.use(function (req, res) { res.sendStatus(200); });
+      localServer.use(function (err, req, res, next) { throw new Error(err, req, res, next); });
+
+      request(localServer)
+        .post('/proxy')
+        .query({ name: 'tobi' })
+        .set('Content-Type', test.encoding)
+        .expect(function (res) {
+          assert(res.body.name === 'tobi');
+          nockedPostWithEncoding.done();
+        })
+        .end(done);
+    });
+
     it('should deliver the post body when ' + test.name, function (done) {
       var nockedPostWithEncoding = nock('http://127.0.0.1:12345')
-        .post('/', { name: 'tobi' })
+        .post('/', test.encoding.includes('json') ? { name: 'tobi' } : {})
         .matchHeader('Content-Type', test.encoding)
         .reply(200, {
           name: 'tobi'
@@ -56,9 +82,9 @@ describe('when proxy request is a POST', function () {
     });
   });
 
-  it('should deliver empty string post body', function (done) {
+  it.only('should deliver empty string post body', function (done) {
     var nockedPostWithoutBody = nock('http://127.0.0.1:12345')
-      .post('/', '')
+      .post('/')
       .matchHeader('Content-Type', 'application/json')
       .reply(200, {
         name: 'tobi'
@@ -70,7 +96,7 @@ describe('when proxy request is a POST', function () {
 
     request(localServer)
       .post('/proxy')
-      .send()
+      .send('')
       .set('Content-Type', 'application/json')
       .expect(function (res) {
         assert(res.body.name === 'tobi');