feat: do NOT dispose extensions

Extensions are instantiated in configuration files thus disposing them
in picker means we must re-use disposed extensions in the next picker.
That behavior is misleading and should be avoided so we must NOT dispose
extension itself.

Author: lambdalisue

denops/fall/main/picker.ts

@@ -16,7 +16,6 @@ import type {
   ItemPickerParams,
 } from "jsr:@vim-fall/std@^0.4.0/config";
 
-import { ensureAsyncDisposable } from "../lib/dispose.ts";
 import {
   getActionPickerParams,
   getGlobalConfig,
@@ -184,7 +183,6 @@ async function startPicker(
     if (!action) {
       throw new Error(`Action "${actionName}" is not found`);
     }
-    await using _guardAction = ensureAsyncDisposable(action);
     const actionParams = {
       // for 'submatch' action
       _submatchContext: {

denops/fall/processor/collect.ts

@@ -5,7 +5,6 @@ import type { Detail, IdItem } from "jsr:@vim-fall/std@^0.4.0/item";
 import type { CollectParams, Source } from "jsr:@vim-fall/std@^0.4.0/source";
 
 import { Chunker } from "../lib/chunker.ts";
-import { dispose } from "../lib/dispose.ts";
 import { dispatch } from "../event.ts";
 
 const THRESHOLD = 100000;
@@ -16,7 +15,7 @@ export type CollectProcessorOptions = {
   chunkSize?: number;
 };
 
-export class CollectProcessor<T extends Detail> implements AsyncDisposable {
+export class CollectProcessor<T extends Detail> implements Disposable {
   readonly #source: Source<T>;
   readonly #threshold: number;
   readonly #chunkSize: number;
@@ -110,12 +109,11 @@ export class CollectProcessor<T extends Detail> implements AsyncDisposable {
     this.#paused = undefined;
   }
 
-  async [Symbol.asyncDispose](): Promise<void> {
+  [Symbol.dispose](): void {
     try {
       this.#controller.abort(null);
     } catch {
       // Ignore
     }
-    await dispose(this.#source);
   }
 }

denops/fall/processor/match.ts

@@ -5,7 +5,6 @@ import type { Detail, IdItem } from "jsr:@vim-fall/std@^0.4.0/item";
 import type { Matcher, MatchParams } from "jsr:@vim-fall/std@^0.4.0/matcher";
 
 import { Chunker } from "../lib/chunker.ts";
-import { dispose } from "../lib/dispose.ts";
 import { dispatch } from "../event.ts";
 
 const INTERVAL = 0;
@@ -19,7 +18,7 @@ export type MatchProcessorOptions = {
   incremental?: boolean;
 };
 
-export class MatchProcessor<T extends Detail> implements AsyncDisposable {
+export class MatchProcessor<T extends Detail> implements Disposable {
   readonly #matchers: readonly [Matcher<T>, ...Matcher<T>[]];
   readonly #interval: number;
   readonly #threshold: number;
@@ -138,12 +137,11 @@ export class MatchProcessor<T extends Detail> implements AsyncDisposable {
       });
   }
 
-  async [Symbol.asyncDispose]() {
+  [Symbol.dispose](): void {
     try {
       this.#controller.abort(null);
     } catch {
       // Ignore
     }
-    await Promise.all(this.#matchers.map((v) => dispose(v)));
   }
 }

denops/fall/processor/preview.ts

@@ -5,10 +5,9 @@ import type {
   PreviewParams,
 } from "jsr:@vim-fall/std@^0.4.0/previewer";
 
-import { dispose } from "../lib/dispose.ts";
 import { dispatch } from "../event.ts";
 
-export class PreviewProcessor<T extends Detail> implements AsyncDisposable {
+export class PreviewProcessor<T extends Detail> implements Disposable {
   readonly #previewers: Previewer<T>[];
   readonly #controller: AbortController = new AbortController();
   #processing?: Promise<void>;
@@ -94,12 +93,11 @@ export class PreviewProcessor<T extends Detail> implements AsyncDisposable {
       });
   }
 
-  async [Symbol.asyncDispose]() {
+  [Symbol.dispose](): void {
     try {
       this.#controller.abort(null);
     } catch {
       // Ignore
     }
-    await Promise.all(this.#previewers.map((v) => dispose(v)));
   }
 }

denops/fall/processor/render.ts

@@ -7,7 +7,6 @@ import type {
 import type { Renderer } from "jsr:@vim-fall/std@^0.4.0/renderer";
 
 import { adjustOffset } from "../lib/adjust_offset.ts";
-import { dispose } from "../lib/dispose.ts";
 import { dispatch } from "../event.ts";
 
 const HEIGHT = 10;
@@ -18,7 +17,7 @@ export type RenderProcessorOptions = {
   scrollOffset?: number;
 };
 
-export class RenderProcessor<T extends Detail> implements AsyncDisposable {
+export class RenderProcessor<T extends Detail> implements Disposable {
   readonly #renderers: Renderer<T>[];
   #height: number;
   #scrollOffset: number;
@@ -183,12 +182,11 @@ export class RenderProcessor<T extends Detail> implements AsyncDisposable {
       });
   }
 
-  async [Symbol.asyncDispose]() {
+  [Symbol.dispose](): void {
     try {
       this.#controller.abort(null);
     } catch {
       // Ignore
     }
-    await Promise.all(this.#renderers.map((v) => dispose(v)));
   }
 }

denops/fall/processor/sort.ts

@@ -2,10 +2,9 @@ import type { Denops } from "jsr:@denops/std@^7.3.2";
 import type { Detail, IdItem } from "jsr:@vim-fall/std@^0.4.0/item";
 import type { Sorter } from "jsr:@vim-fall/std@^0.4.0/sorter";
 
-import { dispose } from "../lib/dispose.ts";
 import { dispatch } from "../event.ts";
 
-export class SortProcessor<T extends Detail> implements AsyncDisposable {
+export class SortProcessor<T extends Detail> implements Disposable {
   readonly #sorters: Sorter<T>[];
   readonly #controller: AbortController = new AbortController();
   #processing?: Promise<void>;
@@ -87,12 +86,11 @@ export class SortProcessor<T extends Detail> implements AsyncDisposable {
       });
   }
 
-  async [Symbol.asyncDispose]() {
+  [Symbol.dispose](): void {
     try {
       this.#controller.abort(null);
     } catch {
       // Ignore
     }
-    await Promise.all(this.#sorters.map((v) => dispose(v)));
   }
 }