Skip to content

Conversation

@ryoppippi
Copy link
Member

この実装が正しいのか自信はないので、おかしかったら教えてください!

Copy link
Contributor

@staticWagomU staticWagomU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!LGTM!!LGTM!!LGTM!!LGTM!!LGTM!!
いくつかコメントしましたが、Approveです!
LGTM!!LGTM!!LGTM!!LGTM!!LGTM!!LGTM!!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

【質問】
public/*からsrc/*に移動した理由は最適化のためでしょうか?
参考:https://docs.astro.build/en/guides/images/#where-to-store-images

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最適化のためです!あと開発環境でパスエラーが出ていました
もしよくないならやめたほうがいいかも

redirects: {
'/': '/2025/ja',
'/2025': '/2025/ja',
'/': '/2025',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

【質問&提案】
metaタグでredirectするのであればastro.configのredirect指定は不要かと思ったんですが、ブラウザによってはうまく動作しないといったことがあるんでしょうか?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

念のため残しておきました。もし消しても問題ないなら消してしまってもいいかもしれないですね

Comment on lines 4 to 6
<Layout />

<meta http-equiv="refresh" content="0;url=/2025/ja" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

【提案】

Suggested change
<Layout />
<meta http-equiv="refresh" content="0;url=/2025/ja" />
<Layout>
<Fragment slot="header">
<meta http-equiv="refresh" content="0;url=/2025/ja" />
</Fragment>
</Layout>

astro wayに乗るならこういった書き方もできます

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あーなるほど確かに
良さそうですね

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2025/src/pages/index.astroのslot案を採用する場合は、headerタグ内に<slot name="header" />を追加する必要があります。

@ryoppippi
Copy link
Member Author

ありがとうございます。後ほど対応しておきます

@ryoppippi ryoppippi requested a review from staticWagomU March 1, 2025 20:37
@ryoppippi
Copy link
Member Author

@staticWagomU 修正してみました!

Copy link
Contributor

@staticWagomU staticWagomU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!!!!すでMTGL

@ryoppippi ryoppippi merged commit 79daf1c into main Mar 2, 2025
6 checks passed
@ryoppippi ryoppippi deleted the feature/use-index-for-redirect branch March 2, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants