-
Notifications
You must be signed in to change notification settings - Fork 41
/2025 パスでもOGPが出るようにindex.astroページを作成
#180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
staticWagomU
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!LGTM!!LGTM!!LGTM!!LGTM!!LGTM!!
いくつかコメントしましたが、Approveです!
LGTM!!LGTM!!LGTM!!LGTM!!LGTM!!LGTM!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
【質問】
public/*からsrc/*に移動した理由は最適化のためでしょうか?
参考:https://docs.astro.build/en/guides/images/#where-to-store-images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
最適化のためです!あと開発環境でパスエラーが出ていました
もしよくないならやめたほうがいいかも
2025/astro.config.mjs
Outdated
| redirects: { | ||
| '/': '/2025/ja', | ||
| '/2025': '/2025/ja', | ||
| '/': '/2025', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
【質問&提案】
metaタグでredirectするのであればastro.configのredirect指定は不要かと思ったんですが、ブラウザによってはうまく動作しないといったことがあるんでしょうか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
念のため残しておきました。もし消しても問題ないなら消してしまってもいいかもしれないですね
2025/src/pages/index.astro
Outdated
| <Layout /> | ||
|
|
||
| <meta http-equiv="refresh" content="0;url=/2025/ja" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
【提案】
| <Layout /> | |
| <meta http-equiv="refresh" content="0;url=/2025/ja" /> | |
| <Layout> | |
| <Fragment slot="header"> | |
| <meta http-equiv="refresh" content="0;url=/2025/ja" /> | |
| </Fragment> | |
| </Layout> |
astro wayに乗るならこういった書き方もできます
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あーなるほど確かに
良さそうですね
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2025/src/pages/index.astroのslot案を採用する場合は、headerタグ内に<slot name="header" />を追加する必要があります。
|
ありがとうございます。後ほど対応しておきます |
|
@staticWagomU 修正してみました! |
staticWagomU
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMです!!!!すでMTGL
この実装が正しいのか自信はないので、おかしかったら教えてください!