Skip to content

Conversation

@gemmaro
Copy link
Contributor

@gemmaro gemmaro commented Sep 30, 2024

No description provided.

Copy link
Member

@h-east h-east left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

指摘箇所以外はLGTMです。

リストや辞書でのこの操作はその場で(in-place)行われる。変更した
くない場合は最初にコピーを作ること: >
:let l = filter(copy(mylist), 'v:val =~ "KEEP"')

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とてもややこしいですが、削除するのは、L3105~L3114だと思います。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L3105~L3114を代わりに削除するよう修正しました。

@gemmaro
Copy link
Contributor Author

gemmaro commented Oct 1, 2024

レビューいただきありがとうございます。
指摘いただいた箇所について修正しました。

@k-takata k-takata merged commit ba9dbf6 into vim-jp:master Oct 2, 2024
2 checks passed
@k-takata
Copy link
Member

k-takata commented Oct 2, 2024

thx

@gemmaro gemmaro deleted the arrange/para branch October 2, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants