Merge pull request #846 from mikoto2000/delete-shell-in-asyncprocess

Author: tsuyoshicho

autoload/vital/__vital__/System/AsyncProcess.vim

@@ -36,7 +36,7 @@ if !s:is_nvim
   endfunction
 
   function! s:_inner_err_cb(user_err_cb, ch, msg) abort
-    call a:user_err_cb(s:_ensure_buffer_string(result))
+    call a:user_err_cb(s:_ensure_buffer_string(a:msg))
   endfunction
 else
   " inner callbacks for Neovim
@@ -83,17 +83,6 @@ function! s:execute(command, options) abort
     throw 'vital: AsyncProcess: invalid argument (value type:' . type(a:command) . ')'
   endif
 
-  " build args
-  let args = []
-  if stridx(&shell, 'cmd.exe') != -1
-    " cmd.exe
-    let args = args + ['/c']
-  else
-    " sh, bash, pwsh, etc.
-    let args = args + ['-c']
-  endif
-  let args = args + [command]
-
   let job_id = -1
   if s:is_nvim
     let options = {}
@@ -107,7 +96,7 @@ function! s:execute(command, options) abort
       let options['on_exit'] = function('s:_inner_exit_cb', [a:options.exit_cb])
     endif
 
-    let job_id = jobstart([&shell] + args, options)
+    let job_id = jobstart(command, options)
 
     if has_key(a:options, 'timeout')
       if a:options.timeout > 0
@@ -130,7 +119,7 @@ function! s:execute(command, options) abort
       let options['exit_cb'] = function('s:_inner_exit_cb', [a:options.exit_cb])
     endif
 
-    let job = job_start([&shell] + args, options)
+    let job = job_start(command, options)
 
     if has_key(a:options, 'timeout')
       if a:options.timeout > 0

test/System/AsyncProcess.vimspec

@@ -47,7 +47,12 @@ Describe System.AsyncProcess
         let g:exit_code = a:exit_code
       endfunction
 
-      let args = 'echo "abcdefg"'
+      if s:is_windows
+        let args = 'cmd.exe /c echo "abcdefg"'
+      else
+        let args = 'bash -c "echo \"abcdefg\""'
+      endif
+
       call AsyncProcess.execute(args, {
         \   'exit_cb': function('s:my_exit_cb'),
         \   'out_cb': function('s:my_out_cb'),
@@ -60,7 +65,7 @@ Describe System.AsyncProcess
       Assert Equals(g:err_msg, "")
 
       if s:is_windows
-        let actual_out_msg = '\"abcdefg\"'
+        let actual_out_msg = '"abcdefg"'
       else
         let actual_out_msg = "abcdefg"
       endif