Skip to content

Allowing a configurable initial max_depth for the Watch Window #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allowing a configurable initial max_depth for the Watch Window #411

wants to merge 2 commits into from

Conversation

Garethp
Copy link

@Garethp Garethp commented Jul 5, 2019 •
edited
Loading

This should address #86

@BlackIkeEagle BlackIkeEagle self-requested a review July 7, 2019 08:24
BlackIkeEagle
BlackIkeEagle reviewed Jul 7, 2019
View reviewed changes
Copy link
Member

@BlackIkeEagle BlackIkeEagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick test shows that it opens the first level, but not more than that even if configured

Screenshot_20190707_101831

@pplanel
Copy link

pplanel commented Jul 28, 2019

This patch breaks the expansion of Superglobals on DebbugerStack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackIkeEagle BlackIkeEagle BlackIkeEagle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Garethp @pplanel @BlackIkeEagle